From: Andi Kleen <andi@firstfloor.org>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
andi@firstfloor.org, tglx@linutronix.de, hpa@linux.intel.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/build] x86, vdso: Error out if the vdso contains external references
Date: Sat, 19 Jun 2010 09:27:45 +0200 [thread overview]
Message-ID: <20100619072745.GA18946@basil.fritz.box> (raw)
In-Reply-To: <tip-05d0b0889ca9d033a960542af7f8a13b3ad4f630@git.kernel.org>
> diff --git a/arch/x86/vdso/checkundef.sh b/arch/x86/vdso/checkundef.sh
> new file mode 100755
> index 0000000..490be1c
> --- /dev/null
> +++ b/arch/x86/vdso/checkundef.sh
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +nm="$1"
> +file="$2"
> +"$nm" "$file" | grep '^ *U' > /dev/null 2>&1
Does that really handle the failed inline, static function case?
In this case you get a function which is not 'U', but it's
just in the wrong section. I think that would need to be checked too.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-19 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-*@vger.kernel.org>
2010-06-18 22:16 ` [tip:x86/build] x86, vdso: Error out if the vdso contains external references tip-bot for H. Peter Anvin
2010-06-19 7:27 ` Andi Kleen [this message]
2010-06-19 15:44 ` H. Peter Anvin
2010-07-28 3:42 ` Stephen Rothwell
2010-07-28 5:25 ` H. Peter Anvin
2010-07-28 7:19 ` [tip:x86/build] x86, vdso: Don't quote $nm in the script for checking vdso references tip-bot for H. Peter Anvin
2010-07-08 7:18 ` [tip:x86/cpu] x86, cpu: Support the features flags in new CPUID leaf 7 tip-bot for H. Peter Anvin
2010-07-28 7:18 ` [tip:x86/asm] x86, asm: Clean up and simplify set_64bit() tip-bot for H. Peter Anvin
2010-08-03 14:09 ` [tip:x86/asm] um, x86: Cast to (u64 *) inside set_64bit() tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619072745.GA18946@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.