From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: anuj.aggarwal@ti.com, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] codecs/tlv320aic23: fix suspend/resume
Date: Sat, 19 Jun 2010 11:59:29 +0100 [thread overview]
Message-ID: <20100619105929.GB2409@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1276937814-10510-1-git-send-email-eric@eukrea.com>
On Sat, Jun 19, 2010 at 10:56:54AM +0200, Eric Bénard wrote:
> The PWR register actually can't be restored at resume because its
> cached value was set to 0xFFFF when suspending and thus the initial
> state won't be restored. Thus, sound doesn't work after resume (tested
> on an i.MX27).
What is the actual problem here?
> + /* backup PWR register */
> + tmp = tlv320aic23_read_reg_cache(codec, TLV320AIC23_PWR);
> + /* turn off the codec */
> tlv320aic23_set_bias_level(codec, SND_SOC_BIAS_OFF);
On power down we put the CODEC into BIAS_OFF...
> - tlv320aic23_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> -
...then we bring the power back up on resume. If there's a problem here
it looks like the bias management functions need fixing but without
knowing what the actual problem with the system is it's not clear what
this is supposed to fix.
next prev parent reply other threads:[~2010-06-19 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 8:56 [PATCH] codecs/tlv320aic23: fix suspend/resume Eric Bénard
2010-06-19 10:59 ` Mark Brown [this message]
2010-06-19 12:07 ` Eric Bénard
2010-06-19 17:33 ` [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume Eric Bénard
2010-06-22 10:07 ` Liam Girdwood
2010-06-22 23:17 ` Mark Brown
2010-06-23 10:35 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619105929.GB2409@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=eric@eukrea.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.