From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove xfs_iput_new
Date: Sat, 19 Jun 2010 16:35:23 -0400 [thread overview]
Message-ID: <20100619203523.GA30665@infradead.org> (raw)
In-Reply-To: <20100615015300.GP6590@dastard>
On Tue, Jun 15, 2010 at 11:53:00AM +1000, Dave Chinner wrote:
> On Fri, Jun 11, 2010 at 12:18:24PM -0400, Christoph Hellwig wrote:
> > We never get an i_mode of 0 or a locked VFS inode until we pass in the
> > XFS_IGET_CREATE flag to xfs_iget, which makes xfs_iput_new equivalent to
> > xfs_iput for the only caller.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
There's in fact no need to lock the inode at all here, so this can
be replaced with IRELE. I'll send an updated version with my next
batch of patches.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-19 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 16:18 [PATCH] xfs: remove xfs_iput_new Christoph Hellwig
2010-06-15 1:53 ` Dave Chinner
2010-06-19 20:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619203523.GA30665@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.