From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Subject: bug i915/intel_tv.c: color bust for NTSC-443
Date: Mon, 21 Jun 2010 13:49:43 +0200
Message-ID: <20100621114943.GD5940@bicker>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com
	[209.85.161.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2F5C39E76B
	for <dri-devel@lists.freedesktop.org>;
	Mon, 21 Jun 2010 04:49:56 -0700 (PDT)
Received: by fxm11 with SMTP id 11so1943617fxm.36
	for <dri-devel@lists.freedesktop.org>;
	Mon, 21 Jun 2010 04:49:54 -0700 (PDT)
Content-Disposition: inline
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Should "colorburst (needed for non-component color)" be enabled or
disabled for "NTSC-443"?

Sparse complains about the current code:

drivers/gpu/drm/i915/intel_tv.c
   477                  .nbr_end        = 240,
   478
   479                  .burst_ena      = 8,
                        ^^^^^^^^^^^^^^^^^^^^
	This should either be true or  false.  8 counts as false.

   480                  .hburst_start   = 72,               .hburst_len = 34,
   481                  .vburst_start_f1 = 9, .vburst_end_f1      = 240,

regards,
dan carpenter