From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dan Carpenter <error27@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H.PeterA" <nvinhpa@zytor.com>,
Venkatesh Pallipadi <venki@google.com>,
Jack Steiner <steiner@sgi.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [patch] x86, pat: freeing invalid memtype messages
Date: Mon, 21 Jun 2010 17:33:03 +0200 [thread overview]
Message-ID: <20100621153303.GA2754@joi.lan> (raw)
In-Reply-To: <4C1F47EF.2060509@redhat.com>
On Mon, Jun 21, 2010 at 07:07:27PM +0800, Xiaotian Feng wrote:
> On 06/21/2010 07:02 PM, Peter Zijlstra wrote:
> > On Mon, 2010-06-21 at 18:56 +0800, Xiaotian Feng wrote:
> >
> >> I guess there might be something wrong between the augmented rbtree insert/remove ..
> >
> > The easiest thing is to revert that change and try again, the next step
> > would be to print the full RB tree on each modification and look where
> > it goes wrong.
> >
> > That said, I did print my fair share of (augmented) RB trees while
> > playing with scheduler patches and I can't remember it ever having
> > messed up like that.
> He's using 2.6.35-rc2+, without your "rbtree: Undo augmented trees
> performance damage" patch ;-)
I applied it manually (commit 2463eb8b3093995e09a0d41b3d78ee0cf5fb4249 from -tip)
to 2.6.35-rc3 and it fixed both acpi's and nouveau's "invalid memtype" messages.
Thanks.
Marcin
next prev parent reply other threads:[~2010-06-21 15:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 13:45 [patch] x86, pat: freeing invalid memtype messages Dan Carpenter
2010-06-17 16:17 ` Marcin Slusarz
2010-06-17 16:33 ` Dan Carpenter
2010-06-18 1:58 ` Xiaotian Feng
2010-06-18 6:47 ` Xiaotian Feng
2010-06-18 17:57 ` Marcin Slusarz
2010-06-21 10:56 ` Xiaotian Feng
2010-06-21 11:02 ` Peter Zijlstra
2010-06-21 11:07 ` Xiaotian Feng
2010-06-21 15:33 ` Marcin Slusarz [this message]
2010-06-21 15:41 ` Peter Zijlstra
2010-06-21 17:54 ` Suresh Siddha
2010-06-21 18:08 ` Venkatesh Pallipadi
2010-06-21 18:38 ` Venkatesh Pallipadi
2010-06-21 18:41 ` Marcin Slusarz
2010-06-21 18:56 ` Marcin Slusarz
2010-06-22 2:45 ` Xiaotian Feng
2010-06-22 3:47 ` Venkatesh Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621153303.GA2754@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=dfeng@redhat.com \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nvinhpa@zytor.com \
--cc=peterz@infradead.org \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.