All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 6/6] bluetooth: make bluetooth.c not a plugin
Date: Mon, 21 Jun 2010 22:59:04 -0500	[thread overview]
Message-ID: <201006212259.04384.denkenz@gmail.com> (raw)
In-Reply-To: <1277023884-27143-6-git-send-email-gustavo@padovan.org>

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hi Gustavo,

> ---
>  Makefile.am         |    7 ++++---
>  plugins/bluetooth.c |    2 --
>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 96116a5..d51d6db 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -71,6 +71,9 @@ gatchat_sources = gatchat/gatchat.h gatchat/gatchat.c \
>  				gatchat/ppp_auth.c gatchat/ppp_net.c \
>  				gatchat/ppp_ipcp.c
> 
> +bluetooth_sources = plugins/bluetooth.c plugins/bluetooth.h
> +
> +
>  udev_files = plugins/ofono.rules
> 
>  if UDEV
> @@ -133,6 +136,7 @@ endif
>  if ATMODEM
>  builtin_modules += atmodem
>  builtin_sources += $(gatchat_sources) \
> +				$(bluetooth_sources) \

This seems really wrong, ATMODEM has nothing to do with bluetooth.

Is it possible to break bluetooth.c library out completely, similar to 
GAtChat?  Do you feel there'll be enough shared between dun/hfp/sap to do so?

Regards,
-Denis

  reply	other threads:[~2010-06-22  3:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-20  8:51 [PATCH 1/6] bluetooth: Move functions from hfp.c to bluetooth.c Gustavo F. Padovan
2010-06-20  8:51 ` [PATCH 2/6] bluetooth: add device_properties_cb() and has_uuid() Gustavo F. Padovan
2010-06-20  8:51   ` [PATCH 3/6] bluetooth: add watches for the bluetoothd service and adapters Gustavo F. Padovan
2010-06-20  8:51     ` [PATCH 4/6] bluetooth: add PropertyChanged watch Gustavo F. Padovan
2010-06-20  8:51       ` [PATCH 5/6] hfp: use bluetooth helpers and remove similar code Gustavo F. Padovan
2010-06-20  8:51         ` [PATCH 6/6] bluetooth: make bluetooth.c not a plugin Gustavo F. Padovan
2010-06-22  3:59           ` Denis Kenzior [this message]
2010-06-22  3:56 ` [PATCH 1/6] bluetooth: Move functions from hfp.c to bluetooth.c Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006212259.04384.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.