From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon,
Date: Tue, 22 Jun 2010 08:45:57 +0000 [thread overview]
Message-ID: <20100622084557.GA4524@loge.amd.com> (raw)
From: Andreas Herrmann <andreas.herrmann3@amd.com>
Reported temperature for ASB1 CPUs is too high.
Add ASB1 CPU revisions (these are also non-desktop variants) to the
list of CPUs for which the temperature fixup is not required.
Example: (from LENOVO ThinkPad Edge 13, 01972NG, system was idle)
Current kernel reports
$ sensors
k8temp-pci-00c3
Adapter: PCI adapter
Core0 Temp: +74.0°C
Core0 Temp: +70.0°C
Core1 Temp: +69.0°C
Core1 Temp: +70.0°C
With this patch I have
$ sensors
k8temp-pci-00c3
Adapter: PCI adapter
Core0 Temp: +54.0°C
Core0 Temp: +51.0°C
Core1 Temp: +48.0°C
Core1 Temp: +49.0°C
Cc: <stable@kernel.org> # .32.x .33.x, .34.x
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
drivers/hwmon/k8temp.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
I think this patch should go into .35.
Patch was built against Linus' git v2.6.35-rc3-3-g9a3cde2.
(Hope that there is no conflict with your recent fix for single core
CPUs.)
Thanks,
Andreas
diff --git a/drivers/hwmon/k8temp.c b/drivers/hwmon/k8temp.c
index 0ceb6d6..1fdd63e 100644
--- a/drivers/hwmon/k8temp.c
+++ b/drivers/hwmon/k8temp.c
@@ -180,11 +180,13 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
}
if ((model >= 0x69) &&
- !(model = 0xc1 || model = 0x6c || model = 0x7c)) {
+ !(model = 0xc1 || model = 0x6c || model = 0x7c ||
+ model = 0x6b || model = 0x6f || model = 0x7f)) {
/*
- * RevG desktop CPUs (i.e. no socket S1G1 parts)
- * need additional offset, otherwise reported
- * temperature is below ambient temperature
+ * RevG desktop CPUs (i.e. no socket S1G1 or
+ * ASB1 parts) need additional offset,
+ * otherwise reported temperature is below
+ * ambient temperature
*/
data->temp_offset = 21000;
}
--
1.7.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2010-06-22 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 8:45 Andreas Herrmann [this message]
2010-06-22 11:24 ` [lm-sensors] [PATCH] hwmon, Andreas Herrmann
2010-06-22 11:35 ` Jean Delvare
2010-06-22 14:51 ` Jean Delvare
2010-08-16 9:17 ` Andreas Herrmann
2010-08-16 9:21 ` Andreas Herrmann
2010-08-17 16:21 ` Jean Delvare
2010-08-17 16:52 ` Jean Delvare
2010-08-18 8:55 ` Andreas Herrmann
2010-08-18 9:10 ` Andreas Herrmann
2010-08-18 12:13 ` Andreas Herrmann
2010-08-18 12:25 ` Jean Delvare
2010-08-19 8:34 ` Jean Delvare
2010-08-19 10:00 ` Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622084557.GA4524@loge.amd.com \
--to=herrmann.der.user@googlemail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.