From: "John W. Linville" <linville@tuxdriver.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5 v2]wireless:hostap_main.c warning: variable 'iface' set but not used
Date: Tue, 22 Jun 2010 14:13:20 -0400 [thread overview]
Message-ID: <20100622181320.GD2583@tuxdriver.com> (raw)
In-Reply-To: <1277157733-14071-1-git-send-email-justinmattock@gmail.com>
On Mon, Jun 21, 2010 at 03:02:13PM -0700, Justin P. Mattock wrote:
> This is a resend from version one due to trying a different approach
> than the original(probably important to leave netdev_priv() in).
>
> In any case have a look, if there's another approach let me know
> and ill test it out. The below patch fixes a warning im seeing
> when compiling with gcc 4.6.0
>
> CC [M] drivers/net/wireless/hostap/hostap_main.o
> drivers/net/wireless/hostap/hostap_main.c: In function 'hostap_set_multicast_list_queue':
> drivers/net/wireless/hostap/hostap_main.c:744:27: warning: variable 'iface' set but not used
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
I already applied the other version to wireless-next-2.6. I can't
imagine what you mean to accomplish by leaving in a call to netdev_priv
w/o assigning the result to something.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-06-22 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 22:02 [PATCH 1/5 v2]wireless:hostap_main.c warning: variable 'iface' set but not used Justin P. Mattock
2010-06-22 18:13 ` John W. Linville [this message]
2010-06-22 18:34 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622181320.GD2583@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.