From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bw0-f49.google.com ([209.85.214.49]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OROHS-0002SN-0J for kexec@lists.infradead.org; Wed, 23 Jun 2010 11:38:10 +0000 Received: by bwz6 with SMTP id 6so1436599bwz.36 for ; Wed, 23 Jun 2010 04:38:08 -0700 (PDT) Date: Wed, 23 Jun 2010 13:38:07 +0200 From: Frederic Weisbecker Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623113806.GD5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4C21E3F8.9000405@linux.intel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Andi Kleen Cc: Christoph Lameter , WANG Cong , Benjamin Herrenschmidt , Heiko Carstens , Oleg Nesterov , David Howells , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , Sam Ravnborg , Mike Frysinger , Eric Dumazet , Jeff Moyer , Ingo Molnar , KOSAKI Motohiro , David Rientjes , Ingo Molnar , Arnd Bergmann , Steven Rostedt , Michael Ellerman , Ian Munsie , Thomas Gleixner , Johannes Berg , Roland McGrath , Dinakar Guniguntala , Lee Schermerhorn , Arnaldo Carvalho de Melo , Neil Horman , linux-mm@kvack.org, netdev@vger.kernel.org, Jason Baron , Greg Kroah-Hartman , Roel Kluin , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Eric Biederman , linux-fsdevel@vger.kernel.org, Simon Kagstrom , Andrew Morton , "David S. Miller" , Alexander Viro On Wed, Jun 23, 2010 at 12:37:44PM +0200, Andi Kleen wrote: > , Frederic Weisbecker wrote: >> On Wed, Jun 23, 2010 at 12:19:38PM +0200, Andi Kleen wrote: >>> , Ian Munsie wrote: >>>> From: Ian Munsie >>>> >>>> This patch converts numerous trivial compat syscalls through the generic >>>> kernel code to use the COMPAT_SYSCALL_DEFINE family of macros. >>> >>> Why? This just makes the code look uglier and the functions harder >>> to grep for. >> >> >> Because it makes them usable with syscall tracing. > > Ok that information is missing in the changelog then. Agreed, the changelog lacks the purpose of what it does. > Also I hope the uglification<->usefullness factor is really worth it. > The patch is certainly no slouch on the uglification side. It's worth because the kernel's syscall tracing is not complete, we lack all the compat part. These wrappers let us create TRACE_EVENT() for every syscalls automatically. If we had to create them manually, the uglification would be way much more worse. Most syscalls use the syscall wrappers already, so the uglification is there mostly. We just forgot to uglify a bunch of them :) > It also has maintenance costs, e.g. I doubt ctags and cscope > will be able to deal with these kinds of macros, so it has a > high cost for everyone using these tools. For those > it would be actually better if you used separate annotation > that does not confuse standard C parsers. I haven't heard any complains about existing syscalls wrappers. What kind of annotations could solve that? _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f42.google.com (mail-bw0-f42.google.com [209.85.214.42]) by ozlabs.org (Postfix) with ESMTP id B4640B70B9 for ; Wed, 23 Jun 2010 21:38:07 +1000 (EST) Received: by bwz1 with SMTP id 1so2371508bwz.15 for ; Wed, 23 Jun 2010 04:38:04 -0700 (PDT) Date: Wed, 23 Jun 2010 13:38:07 +0200 From: Frederic Weisbecker To: Andi Kleen Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623113806.GD5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4C21E3F8.9000405@linux.intel.com> Cc: Christoph Lameter , WANG Cong , Heiko Carstens , Oleg Nesterov , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , Sam Ravnborg , Mike Frysinger , Eric Dumazet , Jeff Moyer , Ingo Molnar , KOSAKI Motohiro , David Rientjes , Ingo Molnar , Arnd Bergmann , Steven Rostedt , Ian Munsie , Thomas Gleixner , Johannes Berg , Roland McGrath , Lee Schermerhorn , Arnaldo Carvalho de Melo , Neil Horman , linux-mm@kvack.org, netdev@vger.kernel.org, Jason Baron , Greg Kroah-Hartman , Roel Kluin , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Eric Biederman , linux-fsdevel@vger.kernel.org, Simon Kagstrom , Andrew Morton , "David S. Miller" , Alexander Viro List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 23, 2010 at 12:37:44PM +0200, Andi Kleen wrote: > , Frederic Weisbecker wrote: >> On Wed, Jun 23, 2010 at 12:19:38PM +0200, Andi Kleen wrote: >>> , Ian Munsie wrote: >>>> From: Ian Munsie >>>> >>>> This patch converts numerous trivial compat syscalls through the generic >>>> kernel code to use the COMPAT_SYSCALL_DEFINE family of macros. >>> >>> Why? This just makes the code look uglier and the functions harder >>> to grep for. >> >> >> Because it makes them usable with syscall tracing. > > Ok that information is missing in the changelog then. Agreed, the changelog lacks the purpose of what it does. > Also I hope the uglification<->usefullness factor is really worth it. > The patch is certainly no slouch on the uglification side. It's worth because the kernel's syscall tracing is not complete, we lack all the compat part. These wrappers let us create TRACE_EVENT() for every syscalls automatically. If we had to create them manually, the uglification would be way much more worse. Most syscalls use the syscall wrappers already, so the uglification is there mostly. We just forgot to uglify a bunch of them :) > It also has maintenance costs, e.g. I doubt ctags and cscope > will be able to deal with these kinds of macros, so it has a > high cost for everyone using these tools. For those > it would be actually better if you used separate annotation > that does not confuse standard C parsers. I haven't heard any complains about existing syscalls wrappers. What kind of annotations could solve that? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Date: Wed, 23 Jun 2010 13:38:07 +0200 Message-ID: <20100623113806.GD5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ian Munsie , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Jason Baron , Steven Rostedt , Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , Andrew Morton , Jeff Moyer , David Howells , Oleg Nesterov , Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Dinakar Guniguntala , Thomas Gleixner , Ingo Molnar , Eric Biederman , Simon Kagstrom , WANG Cong , Sam Ravnborg , Rol To: Andi Kleen Return-path: Content-Disposition: inline In-Reply-To: <4C21E3F8.9000405@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jun 23, 2010 at 12:37:44PM +0200, Andi Kleen wrote: > , Frederic Weisbecker wrote: >> On Wed, Jun 23, 2010 at 12:19:38PM +0200, Andi Kleen wrote: >>> , Ian Munsie wrote: >>>> From: Ian Munsie >>>> >>>> This patch converts numerous trivial compat syscalls through the generic >>>> kernel code to use the COMPAT_SYSCALL_DEFINE family of macros. >>> >>> Why? This just makes the code look uglier and the functions harder >>> to grep for. >> >> >> Because it makes them usable with syscall tracing. > > Ok that information is missing in the changelog then. Agreed, the changelog lacks the purpose of what it does. > Also I hope the uglification<->usefullness factor is really worth it. > The patch is certainly no slouch on the uglification side. It's worth because the kernel's syscall tracing is not complete, we lack all the compat part. These wrappers let us create TRACE_EVENT() for every syscalls automatically. If we had to create them manually, the uglification would be way much more worse. Most syscalls use the syscall wrappers already, so the uglification is there mostly. We just forgot to uglify a bunch of them :) > It also has maintenance costs, e.g. I doubt ctags and cscope > will be able to deal with these kinds of macros, so it has a > high cost for everyone using these tools. For those > it would be actually better if you used separate annotation > that does not confuse standard C parsers. I haven't heard any complains about existing syscalls wrappers. What kind of annotations could solve that? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 9F7D06B0071 for ; Wed, 23 Jun 2010 07:38:10 -0400 (EDT) Received: by bwz4 with SMTP id 4so2600418bwz.14 for ; Wed, 23 Jun 2010 04:38:08 -0700 (PDT) Date: Wed, 23 Jun 2010 13:38:07 +0200 From: Frederic Weisbecker Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623113806.GD5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C21E3F8.9000405@linux.intel.com> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Ian Munsie , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Jason Baron , Steven Rostedt , Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , Andrew Morton , Jeff Moyer , David Howells , Oleg Nesterov , Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Dinakar Guniguntala , Thomas Gleixner , Ingo Molnar , Eric Biederman , Simon Kagstrom , WANG Cong , Sam Ravnborg , Roland McGrath , "H. Peter Anvin" , Mike Frysinger , Neil Horman , Eric Dumazet , Lee Schermerhorn , KOSAKI Motohiro , Christoph Lameter , David Rientjes , Arnaldo Carvalho de Melo , Heiko Carstens , Johannes Berg , Roel Kluin , linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, netdev@vger.kernel.org List-ID: On Wed, Jun 23, 2010 at 12:37:44PM +0200, Andi Kleen wrote: > , Frederic Weisbecker wrote: >> On Wed, Jun 23, 2010 at 12:19:38PM +0200, Andi Kleen wrote: >>> , Ian Munsie wrote: >>>> From: Ian Munsie >>>> >>>> This patch converts numerous trivial compat syscalls through the generic >>>> kernel code to use the COMPAT_SYSCALL_DEFINE family of macros. >>> >>> Why? This just makes the code look uglier and the functions harder >>> to grep for. >> >> >> Because it makes them usable with syscall tracing. > > Ok that information is missing in the changelog then. Agreed, the changelog lacks the purpose of what it does. > Also I hope the uglification<->usefullness factor is really worth it. > The patch is certainly no slouch on the uglification side. It's worth because the kernel's syscall tracing is not complete, we lack all the compat part. These wrappers let us create TRACE_EVENT() for every syscalls automatically. If we had to create them manually, the uglification would be way much more worse. Most syscalls use the syscall wrappers already, so the uglification is there mostly. We just forgot to uglify a bunch of them :) > It also has maintenance costs, e.g. I doubt ctags and cscope > will be able to deal with these kinds of macros, so it has a > high cost for everyone using these tools. For those > it would be actually better if you used separate annotation > that does not confuse standard C parsers. I haven't heard any complains about existing syscalls wrappers. What kind of annotations could solve that? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org