From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f42.google.com (mail-bw0-f42.google.com [209.85.214.42]) by ozlabs.org (Postfix) with ESMTP id DDB25B70D3 for ; Wed, 23 Jun 2010 21:41:19 +1000 (EST) Received: by bwz1 with SMTP id 1so2373042bwz.15 for ; Wed, 23 Jun 2010 04:41:17 -0700 (PDT) Date: Wed, 23 Jun 2010 13:41:17 +0200 From: Frederic Weisbecker To: Christoph Hellwig Subject: Re: [PATCH 12/40] x86, compat: convert ia32 layer to use Message-ID: <20100623114116.GE5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-13-git-send-email-imunsie@au1.ibm.com> <20100623101402.GA10564@lst.de> <20100623103619.GC5242@nowhere> <20100623104603.GB11845@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100623104603.GB11845@lst.de> Cc: Jason Baron , x86@kernel.org, Greg Ungerer , linux-kernel@vger.kernel.org, Steven Rostedt , linuxppc-dev@ozlabs.org, Ingo Molnar , Paul Mackerras , Ian Munsie , "H. Peter Anvin" , Russell King , Thomas Gleixner , Andrew Morton List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 23, 2010 at 12:46:04PM +0200, Christoph Hellwig wrote: > On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: > > I think we wanted that to keep the sys32_ prefixed based naming, to avoid > > collisions with generic compat handler names. > > For native syscalls we do this by adding a arch prefix inside the > syscall name, e.g.: > > arch/s390/kernel/sys_s390.c:SYSCALL_DEFINE(s390_fallocate)(int fd, int mode, loff_t offset, > arch/sparc/kernel/sys_sparc_64.c:SYSCALL_DEFINE1(sparc_pipe_real, struct pt_regs *, regs) In fact we sort of wanted to standardize the name of arch overriden compat syscalls, so that userspace programs playing with syscalls tracing won't have to deal with arch naming differences. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942Ab0FWLlW (ORCPT ); Wed, 23 Jun 2010 07:41:22 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:36011 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232Ab0FWLlV (ORCPT ); Wed, 23 Jun 2010 07:41:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=SkmbT7w4LlXNyXY4K5VyyGxEi4ynLEhXmDx245nl8GA3HQuWqQ830h/X9qemtr6vkH hXS43L7FxTVAV8cXbtjjpK6CdX4SYxLwYedoG/l7OL0sJNL25zpO6exsTuQD+t9Ptb3t FsbzxEXGYVLSKkp1Z7P+AQHecrCABl+SwrHfI= Date: Wed, 23 Jun 2010 13:41:17 +0200 From: Frederic Weisbecker To: Christoph Hellwig Cc: Ian Munsie , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, x86@kernel.org, Jason Baron , "H. Peter Anvin" , Greg Ungerer , Steven Rostedt , Ingo Molnar , Paul Mackerras , Russell King , Thomas Gleixner , Andrew Morton Subject: Re: [PATCH 12/40] x86, compat: convert ia32 layer to use Message-ID: <20100623114116.GE5242@nowhere> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-13-git-send-email-imunsie@au1.ibm.com> <20100623101402.GA10564@lst.de> <20100623103619.GC5242@nowhere> <20100623104603.GB11845@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100623104603.GB11845@lst.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2010 at 12:46:04PM +0200, Christoph Hellwig wrote: > On Wed, Jun 23, 2010 at 12:36:21PM +0200, Frederic Weisbecker wrote: > > I think we wanted that to keep the sys32_ prefixed based naming, to avoid > > collisions with generic compat handler names. > > For native syscalls we do this by adding a arch prefix inside the > syscall name, e.g.: > > arch/s390/kernel/sys_s390.c:SYSCALL_DEFINE(s390_fallocate)(int fd, int mode, loff_t offset, > arch/sparc/kernel/sys_sparc_64.c:SYSCALL_DEFINE1(sparc_pipe_real, struct pt_regs *, regs) In fact we sort of wanted to standardize the name of arch overriden compat syscalls, so that userspace programs playing with syscalls tracing won't have to deal with arch naming differences.