From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Wed, 23 Jun 2010 08:41:07 -0400 From: Christoph Hellwig Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623124106.GA13200@infradead.org> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> <20100623113806.GD5242@nowhere> <4C21FF9A.2040207@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4C21FF9A.2040207@linux.intel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Andi Kleen Cc: Christoph Lameter , WANG Cong , Frederic Weisbecker , Heiko Carstens , Oleg Nesterov , David Howells , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , Sam Ravnborg , Mike Frysinger , Eric Dumazet , Jeff Moyer , Ingo Molnar , KOSAKI Motohiro , Benjamin Herrenschmidt , Ingo Molnar , Arnd Bergmann , David Rientjes , Steven Rostedt , Michael Ellerman , Ian Munsie , Thomas Gleixner , Johannes Berg , Roland McGrath , Dinakar Guniguntala , Lee Schermerhorn , Arnaldo Carvalho de Melo , Neil Horman , linux-mm@kvack.org, netdev@vger.kernel.org, Jason Baron , Greg Kroah-Hartman , Roel Kluin , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Eric Biederman , linux-fsdevel@vger.kernel.org, Simon Kagstrom , Andrew Morton , "David S. Miller" , Alexander Viro On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote: > >I haven't heard any complains about existing syscalls wrappers. > > At least for me they always interrupt my grepping. > > > > >What kind of annotations could solve that? > > If you put the annotation in a separate macro and leave the original > prototype alone. Then C parsers could still parse it. I personally hate the way SYSCALL_DEFINE works with passion, mostly for the grep reason, but also because it looks horribly ugly. But there is no reason not to be consistent here. We already use the wrappers for all native system calls, so leaving the compat calls out doesn't make any sense. And I'd cheer for anyone who comes up with a better scheme for the native and compat wrappers. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 49ED2B7111 for ; Wed, 23 Jun 2010 22:41:21 +1000 (EST) Date: Wed, 23 Jun 2010 08:41:07 -0400 From: Christoph Hellwig To: Andi Kleen Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623124106.GA13200@infradead.org> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> <20100623113806.GD5242@nowhere> <4C21FF9A.2040207@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4C21FF9A.2040207@linux.intel.com> Cc: Christoph Lameter , WANG Cong , Frederic Weisbecker , Heiko Carstens , Oleg Nesterov , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , Sam Ravnborg , Mike Frysinger , Eric Dumazet , Jeff Moyer , Ingo Molnar , KOSAKI Motohiro , Ingo Molnar , Arnd Bergmann , David Rientjes , Steven Rostedt , Ian Munsie , Thomas Gleixner , Johannes Berg , Roland McGrath , Lee Schermerhorn , Arnaldo Carvalho de Melo , Neil Horman , linux-mm@kvack.org, netdev@vger.kernel.org, Jason Baron , Greg Kroah-Hartman , Roel Kluin , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Eric Biederman , linux-fsdevel@vger.kernel.org, Simon Kagstrom , Andrew Morton , "David S. Miller" , Alexander Viro List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote: > >I haven't heard any complains about existing syscalls wrappers. > > At least for me they always interrupt my grepping. > > > > >What kind of annotations could solve that? > > If you put the annotation in a separate macro and leave the original > prototype alone. Then C parsers could still parse it. I personally hate the way SYSCALL_DEFINE works with passion, mostly for the grep reason, but also because it looks horribly ugly. But there is no reason not to be consistent here. We already use the wrappers for all native system calls, so leaving the compat calls out doesn't make any sense. And I'd cheer for anyone who comes up with a better scheme for the native and compat wrappers. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Date: Wed, 23 Jun 2010 08:41:07 -0400 Message-ID: <20100623124106.GA13200@infradead.org> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> <20100623113806.GD5242@nowhere> <4C21FF9A.2040207@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Frederic Weisbecker , Ian Munsie , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Jason Baron , Steven Rostedt , Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , Andrew Morton , Jeff Moyer , David Howells , Oleg Nesterov , Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Dinakar Guniguntala , Thomas Gleixner , Ingo Molnar , Eric Biederman , Simon Kagstrom , WANG Cong Return-path: Content-Disposition: inline In-Reply-To: <4C21FF9A.2040207@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote: > >I haven't heard any complains about existing syscalls wrappers. > > At least for me they always interrupt my grepping. > > > > >What kind of annotations could solve that? > > If you put the annotation in a separate macro and leave the original > prototype alone. Then C parsers could still parse it. I personally hate the way SYSCALL_DEFINE works with passion, mostly for the grep reason, but also because it looks horribly ugly. But there is no reason not to be consistent here. We already use the wrappers for all native system calls, so leaving the compat calls out doesn't make any sense. And I'd cheer for anyone who comes up with a better scheme for the native and compat wrappers. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id AA6296B0071 for ; Wed, 23 Jun 2010 08:42:28 -0400 (EDT) Date: Wed, 23 Jun 2010 08:41:07 -0400 From: Christoph Hellwig Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Message-ID: <20100623124106.GA13200@infradead.org> References: <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com> <1277287401-28571-32-git-send-email-imunsie@au1.ibm.com> <4C21DFBA.2070202@linux.intel.com> <20100623102931.GB5242@nowhere> <4C21E3F8.9000405@linux.intel.com> <20100623113806.GD5242@nowhere> <4C21FF9A.2040207@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C21FF9A.2040207@linux.intel.com> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Frederic Weisbecker , Ian Munsie , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Jason Baron , Steven Rostedt , Ingo Molnar , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , Andrew Morton , Jeff Moyer , David Howells , Oleg Nesterov , Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Dinakar Guniguntala , Thomas Gleixner , Ingo Molnar , Eric Biederman , Simon Kagstrom , WANG Cong , Sam Ravnborg , Roland McGrath , "H. Peter Anvin" , Mike Frysinger , Neil Horman , Eric Dumazet , Lee Schermerhorn , KOSAKI Motohiro , Christoph Lameter , David Rientjes , Arnaldo Carvalho de Melo , Heiko Carstens , Johannes Berg , Roel Kluin , linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, netdev@vger.kernel.org List-ID: On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote: > >I haven't heard any complains about existing syscalls wrappers. > > At least for me they always interrupt my grepping. > > > > >What kind of annotations could solve that? > > If you put the annotation in a separate macro and leave the original > prototype alone. Then C parsers could still parse it. I personally hate the way SYSCALL_DEFINE works with passion, mostly for the grep reason, but also because it looks horribly ugly. But there is no reason not to be consistent here. We already use the wrappers for all native system calls, so leaving the compat calls out doesn't make any sense. And I'd cheer for anyone who comes up with a better scheme for the native and compat wrappers. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org