From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
Anthony Liguori <aliguori@us.ibm.com>,
linux-pci@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH for-2.6.35] virtio-pci: disable msi at startup
Date: Wed, 23 Jun 2010 16:59:47 +0300 [thread overview]
Message-ID: <20100623135946.GA30526@redhat.com> (raw)
In-Reply-To: <4C22132F.4060307@redhat.com>
On Wed, Jun 23, 2010 at 04:59:11PM +0300, Avi Kivity wrote:
> On 06/10/2010 06:22 PM, Michael S. Tsirkin wrote:
>> virtio-pci resets the device at startup by writing to the status
>> register, but this does not clear the pci config space,
>> specifically msi enable status which affects register
>> layout.
>>
>> This breaks things like kdump when they try to use e.g. virtio-blk.
>>
>> Fix by forcing msi off at startup. Since pci.c already has
>> a routine to do this, we export and use it instead of duplicating code.
>>
>>
>
> Why doesn't a device reset result in msi being cleared?
This is not a standard function reset. This is virtio specific
command. So it only clears virtio registers.
> Shouldn't a reset be equivalent to power cycling?
If we did this, driver would need to restore registers
such as BAR etc.
> --
> error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-23 14:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 15:22 [PATCH for-2.6.35] virtio-pci: disable msi at startup Michael S. Tsirkin
2010-06-10 15:34 ` Jesse Barnes
2010-06-10 15:34 ` Jesse Barnes
2010-06-23 13:59 ` Avi Kivity
2010-06-23 13:59 ` Avi Kivity
2010-06-23 13:59 ` Michael S. Tsirkin
2010-06-23 13:59 ` Michael S. Tsirkin [this message]
2010-06-23 14:21 ` Avi Kivity
2010-06-23 14:21 ` Avi Kivity
2010-06-23 14:43 ` Michael S. Tsirkin
2010-06-23 15:15 ` Avi Kivity
2010-06-23 15:26 ` Michael S. Tsirkin
2010-06-23 15:35 ` Avi Kivity
2010-06-23 15:35 ` Avi Kivity
2010-06-23 15:43 ` Michael S. Tsirkin
2010-06-23 15:53 ` Avi Kivity
2010-06-23 15:53 ` Avi Kivity
2010-06-23 15:43 ` Michael S. Tsirkin
2010-06-23 15:51 ` Jesse Barnes
2010-06-23 15:51 ` Jesse Barnes
2010-06-23 15:26 ` Michael S. Tsirkin
2010-06-23 15:15 ` Avi Kivity
2010-06-23 14:43 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2010-06-10 15:22 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623135946.GA30526@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=bjorn.helgaas@hp.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.