From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs
Date: Wed, 23 Jun 2010 17:58:39 +0200 [thread overview]
Message-ID: <201006231758.40146.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20100623150913.GJ15420@lunn.ch>
On Wednesday 23 June 2010 17:09:13 Andrew Lunn wrote:
> There will be a ring buffer per mesh. When debugging problems between
> meshes it is likely both logs will be combined performing a merge
> based on the timestamp. However at this point you have lost
> information about which line belongs to which mesh. Could we maybe
> include the soft interface name in the output?
Actually, this information is (indirectly) present, since each log file resides
inside debugfs/batman_adv/$mesh_if/log. It would be a little bit redundant to
add this on every line, wouldn't you agree ? If someone merges 2 mesh files it
still can be added ?
> Also, do you really want to do jiffies / HZ? You are throwing away
> useful information. Either keep it as jiffies, or scale the remainder
> to ms and print it as well?
You are right - we could leave it as jiffies. Might be the best solution.
Regards,
Marek
next prev parent reply other threads:[~2010-06-23 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 14:20 [B.A.T.M.A.N.] batman-adv debug logging Marek Lindner
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
2010-06-23 14:51 ` Andrew Lunn
2010-06-23 15:02 ` Marek Lindner
2010-06-23 15:12 ` Andrew Lunn
2010-06-23 15:53 ` Marek Lindner
2010-06-23 15:09 ` Andrew Lunn
2010-06-23 15:58 ` Marek Lindner [this message]
2010-06-23 16:12 ` Andrew Lunn
2010-06-23 15:17 ` Sven Eckelmann
2010-06-23 16:00 ` Marek Lindner
2010-06-23 15:23 ` Andrew Lunn
2010-06-23 16:03 ` Marek Lindner
2010-06-23 16:18 ` Andrew Lunn
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: add debug log support Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2010-06-27 0:32 [B.A.T.M.A.N.] batman-adv debug logging (v2) Marek Lindner
2010-06-27 0:33 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006231758.40146.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.