From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com, avi@redhat.com
Subject: Re: [PATCH] make-release: fix mtime on rhel6 beta
Date: Thu, 24 Jun 2010 19:09:15 +0300 [thread overview]
Message-ID: <20100624160915.GA11218@redhat.com> (raw)
In-Reply-To: <20100624161204.GF14947@blackpad.lan.raisama.net>
On Thu, Jun 24, 2010 at 01:12:04PM -0300, Eduardo Habkost wrote:
> On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote:
> > With recent git versions (like one in rhel6 beta),
> > git prints out tag info in addition to
> > requested format, if passed a tag name.
> > This breaks make-release.
> > To get just the time as we want, we need to
> > pass something that is not a tag name but matches
> > same commit. $commit~0 does this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> I suggest using "$commit^{commit}", to make it more clear.
Since which git version does this work?
> > -mtime=`git show --format=%ct "$commit" --`
> > +mtime=`git show --format=%ct "$commit"~0 --`
> > tarargs="--owner=root --group=root --mtime=@$mtime"
>
> --
> Eduardo
next prev parent reply other threads:[~2010-06-24 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 15:48 [PATCH] make-release: fix mtime on rhel6 beta Michael S. Tsirkin
2010-06-24 16:12 ` Eduardo Habkost
2010-06-24 16:09 ` Michael S. Tsirkin [this message]
2010-06-24 17:15 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624160915.GA11218@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.