All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: avi@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com,
	ehabkost@redhat.com
Subject: [PATCHv2] make-release: fix mtime on rhel6 beta
Date: Thu, 24 Jun 2010 20:19:02 +0300	[thread overview]
Message-ID: <20100624171902.GA11367@redhat.com> (raw)

With recent git versions (like one in rhel6 beta),
git prints out tag info in addition to
requested format, if passed a tag name.
This breaks make-release.
To get just the time as we want, we need to
pass something that is not a tag name but matches
same commit.  $commit^{commit} does this.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1: use ^{commit} for clarity.

 kvm/scripts/make-release |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index e8051f4..64e77f9 100755
--- a/kvm/scripts/make-release
+++ b/kvm/scripts/make-release
@@ -51,7 +51,7 @@ cd "$(dirname "$0")"/../..
 mkdir -p "$(dirname "$tarball")"
 git archive --prefix="$name/" --format=tar "$commit" > "$tarball"
 
-mtime=`git show --format=%ct "$commit" --`
+mtime=`git show --format=%ct "$commit""^{commit}" --`
 tarargs="--owner=root --group=root --mtime=@$mtime"
 
 mkdir -p "$tmpdir"
-- 
1.7.1.12.g42b7f

             reply	other threads:[~2010-06-24 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 17:19 Michael S. Tsirkin [this message]
2010-06-28 20:24 ` [PATCHv2] make-release: fix mtime on rhel6 beta Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100624171902.GA11367@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.