From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Date: Sat, 26 Jun 2010 00:38:23 +0000 Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Message-Id: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> List-Id: References: <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On Fri, 25 Jun 2010 21:25:57 +0200 Alexander Graf wrote: > > This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :). > I'm sorry, I thought this change was just trivial code transformation and test for x86 would be OK: but not actually. Probably the reason is around the timing of copy_to_user() and newly introduced clear_user() for clean slot. > > Alex > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Date: Sat, 26 Jun 2010 00:38:23 +0000 Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Message-Id: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> List-Id: References: <20100623145807.07a07c4c.yoshikawa.takuya@oss.ntt.co.jp> <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Takuya Yoshikawa , avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, 25 Jun 2010 21:25:57 +0200 Alexander Graf wrote: > > This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :). > I'm sorry, I thought this change was just trivial code transformation and test for x86 would be OK: but not actually. Probably the reason is around the timing of copy_to_user() and newly introduced clear_user() for clean slot. > > Alex > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Date: Sat, 26 Jun 2010 09:38:23 +0900 Message-ID: <20100626093823.ab4eb33c.takuya.yoshikawa@gmail.com> References: <20100623145807.07a07c4c.yoshikawa.takuya@oss.ntt.co.jp> <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Takuya Yoshikawa , avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, 25 Jun 2010 21:25:57 +0200 Alexander Graf wrote: > > This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :). > I'm sorry, I thought this change was just trivial code transformation and test for x86 would be OK: but not actually. Probably the reason is around the timing of copy_to_user() and newly introduced clear_user() for clean slot. > > Alex >