All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH RFC 1/3] ASoC: uda1380: use callbacks instead of gpiolib
Date: Sun, 27 Jun 2010 11:21:00 +0100	[thread overview]
Message-ID: <20100627102100.GB26394@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201006270012.12854.anarsoul@gmail.com>

On Sun, Jun 27, 2010 at 12:12:05AM +0300, Vasily Khoruzhick wrote:
> В сообщении от 26 июня 2010 23:57:42 автор Mark Brown написал:

> > You definitely should be doing this in the I2C driver not the CODEC driver,
> > you're peering inside the internals of the I2C driver as things stand and
> > are likely to cause problems if someone comes along and implements this in
> > the driver. There's also the fact that all users of the I2C controller
> > will benefit if the code is implemented there, not just this one audio
> > driver.

> I'm afraid that it can cause problems with other i2c-controlled devices, and I 
That's still not dealing with the problems that will arise if someone
does implement this in the core.  To be honest I'm having a hard time
seeing why devices would care - the I2C controller only clocks the bus
during a transfer and otherwise produces no output - so it should just
be an issue for the controller IP.

> can test i2c modification only on h1940 and rx1950 with same codec (uda1380).

Nobody is ever going to be able to test on all possible hardware,
testing is a community effort.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2010-06-27 10:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-26 15:14 [PATCH RFC 0/3] asoc: uda1380 cleanup Vasily Khoruzhick
2010-06-26 15:14 ` [PATCH RFC 1/3] ASoC: uda1380: use callbacks instead of gpiolib Vasily Khoruzhick
2010-06-26 16:40   ` Mark Brown
2010-06-26 16:53     ` Vasily Khoruzhick
2010-06-26 20:09       ` Mark Brown
2010-06-26 20:53         ` Vasily Khoruzhick
2010-06-26 20:57           ` Mark Brown
2010-06-26 21:12             ` Vasily Khoruzhick
2010-06-27 10:21               ` Mark Brown [this message]
2010-06-28 12:00             ` Vasily Khoruzhick
2010-06-28 13:41               ` Mark Brown
2010-06-28 13:49                 ` Vasily Khoruzhick
2010-06-28 13:50                   ` Mark Brown
2010-06-28 14:05                     ` Vasily Khoruzhick
2010-06-28 14:15                       ` Mark Brown
2010-06-28 14:25                         ` Vasily Khoruzhick
     [not found]                       ` <AANLkTilfEIEBaHO8FupS9wU3FR3VGc_yUVNP8KPJ30jW@mail.gmail.com>
2010-06-28 14:32                         ` Mark Brown
2010-06-26 15:14 ` [PATCH RFC 2/3] magician: pass .set_power callback to uda1380 pdata Vasily Khoruzhick
2010-06-26 15:14 ` [PATCH RFC 3/3] uda1380: make driver more powersave-friendly Vasily Khoruzhick
2010-06-26 20:45   ` Mark Brown
2010-06-26 21:07     ` Vasily Khoruzhick
2010-06-27 10:10       ` Mark Brown
2010-06-27 10:43         ` Vasily Khoruzhick
2010-06-27 20:55           ` Mark Brown
2010-06-27 21:15             ` Vasily Khoruzhick
2010-06-27 21:40               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100627102100.GB26394@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anarsoul@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.