From: Andrew Morton <akpm@linux-foundation.org>
To: Samium Gromoff <_deepfire@feelingofgreen.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: MMIO32 support for 8250_early.c
Date: Mon, 28 Jun 2010 13:44:26 -0700 [thread overview]
Message-ID: <20100628134426.0558ac67.akpm@linux-foundation.org> (raw)
In-Reply-To: <87r5jxva3n.fsf@auriga.deep>
On Wed, 23 Jun 2010 23:10:20 +0400
Samium Gromoff <_deepfire@feelingofgreen.ru> wrote:
> This should be fairly uncontroversial, but YMMV.
>
> Available from master branch at git://git.feelingofgreen.ru/linux
>
> commit 67e21ada6739e0730fb28f855abf4202a1bb3f8c
> Author: Samium Gromoff <deepfire@elvees.com>
> Date: Thu Jun 24 00:36:16 2010 +0400
>
> Provide MMIO32 support in 8250_early (aka earlycon)
Please update Documentation/kernel-parameters.txt.
> ...
>
> @@ -182,9 +199,9 @@ static int __init parse_options(struct early_serial8250_device *device,
> }
>
> printk(KERN_INFO "Early serial console at %s 0x%llx (options '%s')\n",
> - mmio ? "MMIO" : "I/O port",
> - mmio ? (unsigned long long) port->mapbase
> - : (unsigned long long) port->iobase,
> + mmio ? "MMIO" : mmio32 ? "MMIO32" : "I/O port",
> + (mmio | mmio32) ? (unsigned long long) port->mapbase
> + : (unsigned long long) port->iobase,
> device->options);
That printk has just got out of control. We should at the very least
parenthesise that ?:?: thing before someone sees it and dies. Or just
rip it up and reimplement it. Note that mapbase can be printed with %p
and iobase with %pr, but the code munges them both into ull's and uses
%llx.
next prev parent reply other threads:[~2010-06-28 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 19:10 [PATCH] serial: MMIO32 support for 8250_early.c Samium Gromoff
2010-06-28 20:44 ` Andrew Morton [this message]
2010-06-30 19:12 ` Samium Gromoff
2010-06-30 20:13 ` Andrew Morton
2010-06-30 21:26 ` Samium Gromoff
-- strict thread matches above, loose matches on Subject: below --
2010-06-26 0:05 Samium Gromoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628134426.0558ac67.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=_deepfire@feelingofgreen.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.