All of lore.kernel.org
 help / color / mirror / Atom feed
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: Assume new page cache pages have dirty D-cache
Date: Mon, 28 Jun 2010 19:52:01 +0530	[thread overview]
Message-ID: <20100628142201.GA3287@debian> (raw)
In-Reply-To: <20100625120132.30030.5577.stgit@e102109-lin.cambridge.arm.com>

On Fri, Jun 25, 2010 at 01:01:32PM +0100, Catalin Marinas wrote:
> @@ -508,6 +508,12 @@ void ___dma_page_dev_to_cpu(struct page *page, unsigned long off,
>  		outer_inv_range(paddr, paddr + size);
>  
>  	dma_cache_maint_page(page, off, size, dir, dmac_unmap_area);
> +
> +	/*
> +	 * Mark the D-cache clean for this page to avoid extra flushing.
> +	 */
> +	if (dir != DMA_TO_DEVICE)
> +		set_bit(PG_dcache_clean, &page->flags);

off + size does not necessarily cover the full page.  We probably
shouldn't be setting it as clean unless it does? 

Also, off + size can cover multiple physically contiguous pages, so
perhaps they too can be set as clean if they're fully covered.

Rabin

  reply	other threads:[~2010-06-28 14:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25 12:01 [PATCH 0/3] Cache maintenance on VIPT caches Catalin Marinas
2010-06-25 12:01 ` [PATCH 1/3] ARM: Assume new page cache pages have dirty D-cache Catalin Marinas
2010-06-28 14:22   ` Rabin Vincent [this message]
2010-06-28 16:49     ` Catalin Marinas
2010-06-25 12:01 ` [PATCH 2/3] ARM: Introduce __sync_icache_dcache() for VIPT caches Catalin Marinas
2010-06-25 12:01 ` [PATCH 3/3] ARM: Use lazy cache flushing on ARMv7 SMP systems Catalin Marinas
2010-07-16 13:19 ` [PATCH 0/3] Cache maintenance on VIPT caches Rabin VINCENT
2010-07-16 14:39   ` Catalin Marinas
2010-07-20  9:56     ` FUJITA Tomonori
2010-07-20  9:56       ` FUJITA Tomonori
2010-07-20 11:37       ` Catalin Marinas
2010-07-20 11:37         ` Catalin Marinas
2010-07-20 11:42         ` Catalin Marinas
2010-07-20 11:42           ` Catalin Marinas
2010-07-20 13:39       ` Catalin Marinas
2010-07-20 13:39         ` Catalin Marinas
2010-07-20 15:22         ` Nicolas Pitre
2010-07-20 15:22           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100628142201.GA3287@debian \
    --to=rabin@rab.in \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.