From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] PATCH fragmentation of unicast packets
Date: Mon, 28 Jun 2010 14:30:31 +0200 [thread overview]
Message-ID: <201006281430.32776.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <20100627172416.62e7554d@rechenknecht>
[-- Attachment #1: Type: Text/Plain, Size: 1409 bytes --]
Marek has published some patches for the debugging infrastructure. Please
adjust your patch for that.
Andreas Langer wrote:
> + if (frag_enabled_tmp < 0) {
> + if (buff[count - 1] == '\n')
> + buff[count - 1] = '\0';
> +
> + printk(KERN_ERR "batman-adv:Invalid parameter for 'frag' setting on
mesh
> %s received: %s\n",
> + net_dev->name, buff);
Please change the printk to a bat_err (remove the batman-adv: and the
information on which mesh it happened).
> + if (atomic_read(&bat_priv->frag_enabled) == frag_enabled_tmp)
> + return count;
> +
> + printk(KERN_INFO "batman-adv:Changing frag from: %s to: %s on mesh:
> %s\n", + atomic_read(&bat_priv->frag_enabled) == 1 ?
> + "enabled" : "disabled",
> + frag_enabled_tmp == 1 ? "enabled" : "disabled",
> + net_dev->name);
That printk to a bat_err (remove the batman-adv: and the information on which
mesh it happened).
> atomic_set(&batman_if->seqno, 1);
> + atomic_set(&batman_if->frag_seqno, 1);
> printk(KERN_INFO "batman-adv:Adding interface: %s\n", batman_if->dev);
Please rebase your patch on top of the current trunk. Otherwise we have an
merge failure here.
> + if (!orig_node) {
> + printk(KERN_WARNING
> + "frag: couldn't find orig node\n");
> + return NET_RX_DROP;
> + }
Please change the printk to pr_warning.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-06-28 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-27 15:24 [B.A.T.M.A.N.] PATCH fragmentation of unicast packets Andreas Langer
2010-06-27 16:15 ` Sven Eckelmann
2010-06-28 12:34 ` Sven Eckelmann
2010-06-28 12:30 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006281430.32776.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.