From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib/format_text format-text.c layout.h
Date: 28 Jun 2010 20:29:57 -0000 [thread overview]
Message-ID: <20100628202957.12913.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski at sourceware.org 2010-06-28 20:29:57
Modified files:
lib/format_text: format-text.c layout.h
Log message:
Add text format specific 'rlocn' ignore flag and access functions.
Adding a flag to the 'rlocn' structure in the mda header of the
text format allows us to flip a bit to ignore an area on disk that
stores the metadata via the text format specific mda_header.
This patch defines the flag and access functions to manage the flag.
Other patches will manage the ignore on a format-independent basis,
by using a flag in the metadata_area structure.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.123&r2=1.124
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/layout.h.diff?cvsroot=lvm2&r1=1.10&r2=1.11
--- LVM2/lib/format_text/format-text.c 2010/06/22 19:18:27 1.123
+++ LVM2/lib/format_text/format-text.c 2010/06/28 20:29:57 1.124
@@ -66,6 +66,19 @@
char *desc; /* Description placed inside file */
};
+int rlocn_is_ignored(const struct raw_locn *rlocn)
+{
+ return (rlocn->flags & RAW_LOCN_IGNORED ? 1 : 0);
+}
+
+void rlocn_set_ignored(struct raw_locn *rlocn, int value)
+{
+ if (value)
+ rlocn->flags |= RAW_LOCN_IGNORED;
+ else
+ rlocn->flags &= ~RAW_LOCN_IGNORED;
+}
+
/*
* NOTE: Currently there can be only one vg per text file.
*/
--- LVM2/lib/format_text/layout.h 2010/06/28 20:29:42 1.10
+++ LVM2/lib/format_text/layout.h 2010/06/28 20:29:57 1.11
@@ -46,6 +46,13 @@
struct disk_locn disk_areas_xl[0]; /* Two lists */
} __attribute__ ((packed));
+/*
+ * Ignore this raw location. This allows us to
+ * ignored metadata areas easily, and thus balance
+ * metadata across VGs with many PVs.
+ */
+#define RAW_LOCN_IGNORED 0x00000001
+
/* On disk */
struct raw_locn {
uint64_t offset; /* Offset in bytes to start sector */
@@ -54,6 +61,9 @@
uint32_t flags;
} __attribute__ ((packed));
+int rlocn_is_ignored(const struct raw_locn *rlocn);
+void rlocn_set_ignored(struct raw_locn *rlocn, int value);
+
/* On disk */
/* Structure size limited to one sector */
struct mda_header {
reply other threads:[~2010-06-28 20:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628202957.12913.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.