From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib format_text/text_label.c metadata/met ...
Date: 28 Jun 2010 20:30:15 -0000 [thread overview]
Message-ID: <20100628203015.13340.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski at sourceware.org 2010-06-28 20:30:14
Modified files:
lib/format_text: text_label.c
lib/metadata : metadata.c metadata.h
Log message:
Add location independent flag and functions to ignore mdas.
First we add a 'flags' field to the location independent
metadata_area structure, and a MDA_IGNORE flag. The
mda_is_ignored and mda_set_ignored functions are added to
manage the flag. Adding the flag and functions gives a
library interface to ignore metadata areas independent of
the underlying location (disk, file, etc). The location
specific read/write functions must then handle the specifics
of what this flag means to the location.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Reviewed-by: Alasdair G Kergon <agk@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/text_label.c.diff?cvsroot=lvm2&r1=1.27&r2=1.28
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.346&r2=1.347
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.h.diff?cvsroot=lvm2&r1=1.205&r2=1.206
--- LVM2/lib/format_text/text_label.c 2009/12/16 19:22:12 1.27
+++ LVM2/lib/format_text/text_label.c 2010/06/28 20:30:14 1.28
@@ -215,6 +215,7 @@
mdal->ops = mda_lists->raw_ops;
mdal->metadata_locn = mdac;
+ mdal->flags = 0;
mdac->area.dev = dev;
mdac->area.start = start;
--- LVM2/lib/metadata/metadata.c 2010/06/22 21:10:53 1.346
+++ LVM2/lib/metadata/metadata.c 2010/06/28 20:30:14 1.347
@@ -3855,6 +3855,19 @@
return pv_field(pv, pe_alloc_count);
}
+unsigned mda_is_ignored(struct metadata_area *mda)
+{
+ return (mda->flags & MDA_IGNORED);
+}
+
+void mda_set_ignored(struct metadata_area *mda, int value)
+{
+ if (value)
+ mda->flags |= MDA_IGNORED;
+ else
+ mda->flags &= ~MDA_IGNORED;
+}
+
uint32_t pv_mda_count(const struct physical_volume *pv)
{
struct lvmcache_info *info;
--- LVM2/lib/metadata/metadata.h 2010/05/24 15:32:20 1.205
+++ LVM2/lib/metadata/metadata.h 2010/06/28 20:30:14 1.206
@@ -158,12 +158,18 @@
};
+#define MDA_IGNORED 0x00000001
+
struct metadata_area {
struct dm_list list;
struct metadata_area_ops *ops;
void *metadata_locn;
+ uint32_t flags;
};
+unsigned mda_is_ignored(struct metadata_area *mda);
+void mda_set_ignored(struct metadata_area *mda, int value);
+
#define seg_pvseg(seg, s) (seg)->areas[(s)].u.pv.pvseg
#define seg_dev(seg, s) (seg)->areas[(s)].u.pv.pvseg->pv->dev
#define seg_pe(seg, s) (seg)->areas[(s)].u.pv.pvseg->pe
next reply other threads:[~2010-06-28 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 20:30 wysochanski [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-29 22:25 LVM2/lib format_text/text_label.c metadata/met wysochanski
2010-06-30 19:28 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628203015.13340.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.