From: Chris Mason <chris.mason@oracle.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Dan Carpenter <error27@gmail.com>,
Yan Zheng <zheng.yan@oracle.com>,
Diego Calleja <diegocg@gmail.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] btrfs: make code reachable in btrfs_insert_some_items()
Date: Mon, 28 Jun 2010 21:04:05 -0400 [thread overview]
Message-ID: <20100629010405.GU1993@think> (raw)
In-Reply-To: <4C294512.8070302@cn.fujitsu.com>
On Tue, Jun 29, 2010 at 08:57:54AM +0800, Miao Xie wrote:
> Hi,
>
> on 2010-6-28 19:17, Dan Carpenter wrote:
> > The break was in front of the "nr = i" assignment so that was never hit.
>
> This bug has been fixed a month ago, and the patch has been merged into the
> btrfs-unstable tree.
This was one that we took out to keep the pull request down to the
critical fixes. That function actually isn't called, I'll just remove
it.
-chris
>
> http://marc.info/?l=linux-btrfs&m=127434036913484&w=2
>
> Thanks
> Miao
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> > index 0d1d966..ceb8ad2 100644
> > --- a/fs/btrfs/ctree.c
> > +++ b/fs/btrfs/ctree.c
> > @@ -3453,8 +3453,8 @@ int btrfs_insert_some_items(struct btrfs_trans_handle *trans,
> > for (i = 0; i < nr; i++) {
> > if (total_size + data_size[i] + sizeof(struct btrfs_item) >
> > BTRFS_LEAF_DATA_SIZE(root)) {
> > - break;
> > nr = i;
> > + break;
> > }
> > total_data += data_size[i];
> > total_size += data_size[i] + sizeof(struct btrfs_item);
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2010-06-29 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 11:17 [patch] btrfs: make code reachable in btrfs_insert_some_items() Dan Carpenter
2010-06-29 0:57 ` Miao Xie
2010-06-29 0:57 ` Miao Xie
2010-06-29 1:04 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629010405.GU1993@think \
--to=chris.mason@oracle.com \
--cc=diegocg@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.