From: Chen Cao <kcao@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST PATCH] KVM test: Windows unattended_install: don't start the telnet service at startup
Date: Tue, 29 Jun 2010 09:33:40 +0800 [thread overview]
Message-ID: <20100629013340.GA3118@t4.rh> (raw)
In-Reply-To: <1277736858-7654-1-git-send-email-mgoldish@redhat.com>
On Mon, Jun 28, 2010 at 05:54:18PM +0300, Michael Goldish wrote:
> The telnet service isn't used by kvm-autotest (AFAIK) and may interfere with
> rss.exe (port 23).
>
Michael,
I think it is better to leave the port 23 (and also 22) alone, people
may want to use both telnet (e.g. telnet is integrited into some
testing tools and/or some other reasons) and rss.exe.
and rss.exe could use other port and we can configure the port NR
through the config file of kvm-autotest to use it.
Regards,
Cao, Chen
2010/06/29
> Signed-off-by: Michael Goldish <mgoldish@redhat.com>
> ---
> client/tests/kvm/unattended/win2003-32.sif | 10 +++-----
> client/tests/kvm/unattended/win2003-64.sif | 10 +++-----
> .../kvm/unattended/win2008-32-autounattend.xml | 18 ++-------------
> .../kvm/unattended/win2008-64-autounattend.xml | 18 ++-------------
> .../kvm/unattended/win2008-r2-autounattend.xml | 18 ++-------------
> .../tests/kvm/unattended/win7-32-autounattend.xml | 22 ++++---------------
> .../tests/kvm/unattended/win7-64-autounattend.xml | 22 ++++---------------
> .../kvm/unattended/winvista-32-autounattend.xml | 18 ++-------------
> .../kvm/unattended/winvista-64-autounattend.xml | 18 ++-------------
> 9 files changed, 33 insertions(+), 121 deletions(-)
>
> diff --git a/client/tests/kvm/unattended/win2003-32.sif b/client/tests/kvm/unattended/win2003-32.sif
> index f58b0b0..d1e8495 100644
> --- a/client/tests/kvm/unattended/win2003-32.sif
> +++ b/client/tests/kvm/unattended/win2003-32.sif
> @@ -56,9 +56,7 @@
> YResolution=768
>
> [GuiRunOnce]
> - Command0="cmd /c sc config TlntSvr start= auto"
> - Command1="cmd /c netsh firewall set opmode disable"
> - Command2="cmd /c net start telnet"
> - Command3="cmd /c E:\setuprss.bat"
> - Command4="cmd /c netsh interface ip set address local dhcp"
> - Command5="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe"
> + Command0="cmd /c netsh firewall set opmode disable"
> + Command1="cmd /c E:\setuprss.bat"
> + Command2="cmd /c netsh interface ip set address local dhcp"
> + Command3="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe"
> diff --git a/client/tests/kvm/unattended/win2003-64.sif b/client/tests/kvm/unattended/win2003-64.sif
> index f58b0b0..d1e8495 100644
> --- a/client/tests/kvm/unattended/win2003-64.sif
> +++ b/client/tests/kvm/unattended/win2003-64.sif
> @@ -56,9 +56,7 @@
> YResolution=768
>
> [GuiRunOnce]
> - Command0="cmd /c sc config TlntSvr start= auto"
> - Command1="cmd /c netsh firewall set opmode disable"
> - Command2="cmd /c net start telnet"
> - Command3="cmd /c E:\setuprss.bat"
> - Command4="cmd /c netsh interface ip set address local dhcp"
> - Command5="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe"
> + Command0="cmd /c netsh firewall set opmode disable"
> + Command1="cmd /c E:\setuprss.bat"
> + Command2="cmd /c netsh interface ip set address local dhcp"
> + Command3="cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe"
> diff --git a/client/tests/kvm/unattended/win2008-32-autounattend.xml b/client/tests/kvm/unattended/win2008-32-autounattend.xml
> index 44a9fc4..74f99b1 100644
> --- a/client/tests/kvm/unattended/win2008-32-autounattend.xml
> +++ b/client/tests/kvm/unattended/win2008-32-autounattend.xml
> @@ -116,30 +116,18 @@
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> <Order>1</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>2</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>4</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>5</Order>
> + <Order>2</Order>
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>6</Order>
> + <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>7</Order>
> + <Order>4</Order>
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> </SynchronousCommand>
> </FirstLogonCommands>
> diff --git a/client/tests/kvm/unattended/win2008-64-autounattend.xml b/client/tests/kvm/unattended/win2008-64-autounattend.xml
> index ea0a524..6e71cfd 100644
> --- a/client/tests/kvm/unattended/win2008-64-autounattend.xml
> +++ b/client/tests/kvm/unattended/win2008-64-autounattend.xml
> @@ -125,30 +125,18 @@
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> <Order>1</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>2</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>4</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>5</Order>
> + <Order>2</Order>
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>6</Order>
> + <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>7</Order>
> + <Order>4</Order>
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> </SynchronousCommand>
> </FirstLogonCommands>
> diff --git a/client/tests/kvm/unattended/win2008-r2-autounattend.xml b/client/tests/kvm/unattended/win2008-r2-autounattend.xml
> index ea0a524..6e71cfd 100644
> --- a/client/tests/kvm/unattended/win2008-r2-autounattend.xml
> +++ b/client/tests/kvm/unattended/win2008-r2-autounattend.xml
> @@ -125,30 +125,18 @@
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> <Order>1</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>2</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>4</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>5</Order>
> + <Order>2</Order>
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>6</Order>
> + <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>7</Order>
> + <Order>4</Order>
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> </SynchronousCommand>
> </FirstLogonCommands>
> diff --git a/client/tests/kvm/unattended/win7-32-autounattend.xml b/client/tests/kvm/unattended/win7-32-autounattend.xml
> index a577a91..39123bf 100644
> --- a/client/tests/kvm/unattended/win7-32-autounattend.xml
> +++ b/client/tests/kvm/unattended/win7-32-autounattend.xml
> @@ -122,36 +122,24 @@
> </AutoLogon>
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - <Order>1</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - <Order>2</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> - <Order>3</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - <Order>4</Order>
> + <Order>1</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> - <Order>5</Order>
> + <Order>2</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> - <Order>6</Order>
> + <Order>3</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> - <Order>7</Order>
> + <Order>4</Order>
> </SynchronousCommand>
> </FirstLogonCommands>
> </component>
> </settings>
> <cpi:offlineImage cpi:source="wim:c:/install.wim#Windows Longhorn SERVERSTANDARD"
> xmlns:cpi="urn:schemas-microsoft-com:cpi" />
> -</unattend>
> \ No newline at end of file
> +</unattend>
> diff --git a/client/tests/kvm/unattended/win7-64-autounattend.xml b/client/tests/kvm/unattended/win7-64-autounattend.xml
> index fec8017..e39b9d7 100644
> --- a/client/tests/kvm/unattended/win7-64-autounattend.xml
> +++ b/client/tests/kvm/unattended/win7-64-autounattend.xml
> @@ -122,36 +122,24 @@
> </AutoLogon>
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - <Order>1</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - <Order>2</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> - <Order>3</Order>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - <Order>4</Order>
> + <Order>1</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> - <Order>5</Order>
> + <Order>2</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> - <Order>6</Order>
> + <Order>3</Order>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> - <Order>7</Order>
> + <Order>4</Order>
> </SynchronousCommand>
> </FirstLogonCommands>
> </component>
> </settings>
> <cpi:offlineImage cpi:source="wim:c:/install.wim#Windows Longhorn SERVERSTANDARD"
> xmlns:cpi="urn:schemas-microsoft-com:cpi" />
> -</unattend>
> \ No newline at end of file
> +</unattend>
> diff --git a/client/tests/kvm/unattended/winvista-32-autounattend.xml b/client/tests/kvm/unattended/winvista-32-autounattend.xml
> index 7835a64..37c6de5 100644
> --- a/client/tests/kvm/unattended/winvista-32-autounattend.xml
> +++ b/client/tests/kvm/unattended/winvista-32-autounattend.xml
> @@ -123,30 +123,18 @@
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> <Order>1</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>2</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>4</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>5</Order>
> + <Order>2</Order>
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>6</Order>
> + <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>7</Order>
> + <Order>4</Order>
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> </SynchronousCommand>
> </FirstLogonCommands>
> diff --git a/client/tests/kvm/unattended/winvista-64-autounattend.xml b/client/tests/kvm/unattended/winvista-64-autounattend.xml
> index ad68bf9..528e6ac 100644
> --- a/client/tests/kvm/unattended/winvista-64-autounattend.xml
> +++ b/client/tests/kvm/unattended/winvista-64-autounattend.xml
> @@ -124,30 +124,18 @@
> <FirstLogonCommands>
> <SynchronousCommand wcm:action="add">
> <Order>1</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c start /w pkgmgr /iu:"TelnetServer"</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>2</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c sc config TlntSvr start= auto</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh firewall set opmode disable</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>4</Order>
> - <CommandLine>%WINDIR%\System32\cmd /c net start telnet</CommandLine>
> - </SynchronousCommand>
> - <SynchronousCommand wcm:action="add">
> - <Order>5</Order>
> + <Order>2</Order>
> <CommandLine>%WINDIR%\System32\cmd /c E:\setuprss.bat</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>6</Order>
> + <Order>3</Order>
> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set address "Local Area Connection" dhcp</CommandLine>
> </SynchronousCommand>
> <SynchronousCommand wcm:action="add">
> - <Order>7</Order>
> + <Order>4</Order>
> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 && A:\finish.exe</CommandLine>
> </SynchronousCommand>
> </FirstLogonCommands>
> --
> 1.5.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Cao, Chen
GnuPG Key-ID:AC54E05E
keyserver hkp://keys.gnupg.net
next prev parent reply other threads:[~2010-06-29 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:54 [KVM-AUTOTEST PATCH] KVM test: Windows unattended_install: don't start the telnet service at startup Michael Goldish
2010-06-29 1:33 ` Chen Cao [this message]
2010-06-29 10:07 ` Michael Goldish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629013340.GA3118@t4.rh \
--to=kcao@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.