All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@nokia.com>
To: "ext Nagarajan, Rajkumar" <x0133774@ti.com>
Cc: "Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>,
	"Mittal, Mukund" <mmittal@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>
Subject: Re: OMAP3 display  patches
Date: Tue, 29 Jun 2010 15:39:02 +0300	[thread overview]
Message-ID: <20100629123902.GZ9381@nokia.com> (raw)
In-Reply-To: <FF55437E1F14DA4BAEB721A458B6701706BDB3A55F@dbde02.ent.ti.com>

On Tue, Jun 29, 2010 at 02:20:36PM +0200, ext Nagarajan, Rajkumar wrote:
> 
> Tomi,
> 
> Would you please check if there are no further comments and can you please pull the following patches in?
>
> https://patchwork.kernel.org/patch/106498/

This one seems to have two separate changes in the same patch. Needs
splitting.

> https://patchwork.kernel.org/patch/106670/

I think this one needs a (cpu_is_omap3630() && id == OMAP_DSS_VIDEO2)
check in store() so that the user gets a proper error if he tries to
write an unsupported value.

> https://patchwork.kernel.org/patch/107547/

You never addressed any of my comments so asking Tomi to pull this
seems rather premature.

-- 
Ville Syrjälä
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-06-29 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 12:20 OMAP3 display patches Nagarajan, Rajkumar
2010-06-29 12:39 ` Ville Syrjälä [this message]
2010-06-30  9:48 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629123902.GZ9381@nokia.com \
    --to=ville.syrjala@nokia.com \
    --cc=Tomi.Valkeinen@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mmittal@ti.com \
    --cc=tony@atomide.com \
    --cc=x0133774@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.