From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses
Date: Tue, 29 Jun 2010 14:23:43 +0200 [thread overview]
Message-ID: <20100629142343.7ecadfaa@wker> (raw)
In-Reply-To: <m2vd9283ew.fsf@ohwell.denx.de>
Hi Detlev, Hi Wolfgang,
On Tue, 29 Jun 2010 13:49:11 +0200
Detlev Zundel <dzu@denx.de> wrote:
> > Commit 460c2ce3 "MPC5200: workaround data corruption for unaligned
> > local bus accesses" fixed the problem for MPC5200 only, but MPC512x is
> > affected as well, so apply the same fix here, too.
> >
> > Signed-off-by: Wolfgang Denk <wd@denx.de>
> > Cc: Detlev Zundel <dzu@denx.de>
> > Cc: Anatolij Gustschin <agust@denx.de>
> > ---
> > arch/powerpc/cpu/mpc5xxx/Makefile | 5 -----
> > arch/powerpc/lib/Makefile | 16 ++++++++++++----
> > arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c | 0
> > 3 files changed, 12 insertions(+), 9 deletions(-)
> > rename arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c (100%)
>
> Acked-by: Detlev Zundel <dzu@denx.de>
>
> The only thing I wonder is the filename 'memcpy_mpc5200.c' as the code
> doesn't really have any 5200 specifics in it. What about
> 'memcpy_align32wrap' or something likew that to express the more general
> nature of the code?
'memcpy_align32wrap' isn't really good since the fixed memcpy
also fixes 16-bit accesses, too.
BTW, shouldn't we fix print_buffer() also? do_mem_md() doesn't use
memcpy() and the issue with corrupted dumps still remains here.
I'm testing a patch to fix it. Will submit it soon.
Best regards,
Anatolij
next prev parent reply other threads:[~2010-06-29 12:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 20:29 [U-Boot] [PATCH] MPC5200: workaround data corruption for unaligned local bus accesses Wolfgang Denk
2010-06-22 23:10 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2010-06-23 0:12 ` [U-Boot] [PATCH v3] " Wolfgang Denk
2010-06-25 8:35 ` Detlev Zundel
2010-06-29 9:48 ` [U-Boot] [PATCH] MPC512x: " Wolfgang Denk
2010-06-29 11:49 ` Detlev Zundel
2010-06-29 12:09 ` Wolfgang Denk
2010-06-29 12:41 ` Detlev Zundel
2010-06-29 12:42 ` Joakim Tjernlund
2010-06-29 12:55 ` Wolfgang Denk
2010-06-29 13:06 ` Joakim Tjernlund
2010-06-29 14:21 ` Joakim Tjernlund
2010-06-29 16:19 ` [U-Boot] [PATCH] MPC512x: workaround data corruption forunaligned " Steve Deiters
2010-06-29 19:24 ` Wolfgang Denk
2010-06-29 21:47 ` Joakim Tjernlund
2010-06-29 12:23 ` Anatolij Gustschin [this message]
2010-06-29 12:47 ` [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned " Wolfgang Denk
2010-06-29 13:34 ` Anatolij Gustschin
2010-06-29 12:45 ` [U-Boot] [PATCH] Use memcpy in print_buffer to fix unaligned dumps Anatolij Gustschin
2010-06-29 12:53 ` Wolfgang Denk
2010-06-29 12:57 ` Wolfgang Denk
2010-06-29 19:42 ` Mike Frysinger
2010-06-29 19:29 ` [U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629142343.7ecadfaa@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.