diff for duplicates of <20100629143128.GB14944@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 032f584..e7d6109 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,7 +15,7 @@ Comments inline. And thanks a lot for your time! Guenter > -> > Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> +> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> > > --- > > drivers/hwmon/Kconfig | 12 + > > drivers/hwmon/Makefile | 1 + @@ -504,7 +504,7 @@ ok. > > + val = mantissa * 1000L; > > + > > + /* scale result to micro-units for power sensors */ -> > + if (class == PSC_POWER) +> > + if (class = PSC_POWER) > > + val = val * 1000L; > > + > > + if (exponent > 0) @@ -534,7 +534,7 @@ Good point. > > + b = data->b[class]; > > + R = data->R[class]; > > + -> > + if (m == 0) +> > + if (m = 0) > > + return 0; > > + > > + /* X = 1/m * (Y * 10^-R - b) */ @@ -542,7 +542,7 @@ Good point. > > + b *= 1000; /* subtract milli-units */ > > + > > + /* scale result to micro-units for power sensors */ -> > + if (class == PSC_POWER) { +> > + if (class = PSC_POWER) { > > + R += 3; > > + b *= 1000; > > + } @@ -582,7 +582,7 @@ Good point. > > + bool negative = false; > > + > > + /* simple case */ -> > + if (val == 0) +> > + if (val = 0) > > + return 0; > > + > > + if (val < 0) { @@ -591,7 +591,7 @@ Good point. > > + } > > + > > + /* Power is in uW. Convert to mW before converting. */ -> > + if (class == PSC_POWER) +> > + if (class = PSC_POWER) > > + val = DIV_ROUND_CLOSEST(val, 1000L); > > + > > + /* Reduce large mantissa until it fits into 10 bit */ @@ -630,7 +630,7 @@ Good point. > > + R = data->R[class]; > > + > > + /* Power is in uW. Adjust R. */ -> > + if (class == PSC_POWER) +> > + if (class = PSC_POWER) > > + R -= 3; > > + > > + /* Calculate Y = (m * X + b) * 10^R */ @@ -935,7 +935,7 @@ Any thoughts ? > > + data->R[i] = pmbus_config[data->type].R[i]; > > + } > > + -> > + if (data->type == pmbus) { +> > + if (data->type = pmbus) { > > + /* > > + * We could try to determine supported options here. > > + * However, it appears that hardly any chips support @@ -1656,4 +1656,9 @@ Again, a matter of defensive programming. I would prefer to keep it. > > +#define PB_CML_FAULT_INVALID_COMMAND (1<<7) > > + > > +#endif /* PB_H */ -> +> + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 1e493e9..ec43012 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,26 +1,25 @@ "ref\01277762214-15155-1-git-send-email-guenter.roeck@ericsson.com\0" "ref\01277762214-15155-3-git-send-email-guenter.roeck@ericsson.com\0" "ref\04C29F7EB.6020602@jic23.retrosnub.co.uk\0" - "ref\04C29F7EB.6020602-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org\0" - "From\0Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>\0" - "Subject\0Re: [PATCH/RFC 2/4] hwmon: PMBus device driver\0" - "Date\0Tue, 29 Jun 2010 07:31:28 -0700\0" - "To\0Jonathan Cameron <kernel-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org>\0" - "Cc\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" - Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> - Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> - Ira W. Snyder <iws-lulEs6mt1IksTUYHLfqkUA@public.gmane.org> - Darrick J. Wong <djwong-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> - Ben Dooks (embedded platforms) <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> - Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> - Crane Cai <crane.cai-5C7GfCeVMHo@public.gmane.org> - Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> - Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" + "Subject\0Re: [lm-sensors] [PATCH/RFC 2/4] hwmon: PMBus device driver\0" + "Date\0Tue, 29 Jun 2010 14:31:28 +0000\0" + "To\0Jonathan Cameron <kernel@jic23.retrosnub.co.uk>\0" + "Cc\0Jean Delvare <khali@linux-fr.org>" + Randy Dunlap <rdunlap@xenotime.net> + Andrew Morton <akpm@linux-foundation.org> + Ira W. Snyder <iws@ovro.caltech.edu> + Darrick J. Wong <djwong@us.ibm.com> + Ben Dooks (embedded platforms) <ben-linux@fluff.org> + Hans de Goede <hdegoede@redhat.com> + Mark Brown <broonie@opensource.wolfsonmicro.com> + Samuel Ortiz <sameo@linux.intel.com> + Crane Cai <crane.cai@amd.com> + Linus Walleij <linus.walleij@stericsson.com> + Ralf Baechle <ralf@linux-mips.org> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-i2c@vger.kernel.org <linux-i2c@vger.kernel.org>\0" "\00:1\0" "b\0" "On Tue, Jun 29, 2010 at 09:40:59AM -0400, Jonathan Cameron wrote:\n" @@ -40,7 +39,7 @@ "Guenter\n" "\n" "> \n" - "> > Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>\n" + "> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>\n" "> > ---\n" "> > drivers/hwmon/Kconfig | 12 +\n" "> > drivers/hwmon/Makefile | 1 +\n" @@ -529,7 +528,7 @@ "> > + val = mantissa * 1000L;\n" "> > +\n" "> > + /* scale result to micro-units for power sensors */\n" - "> > + if (class == PSC_POWER)\n" + "> > + if (class = PSC_POWER)\n" "> > + val = val * 1000L;\n" "> > +\n" "> > + if (exponent > 0)\n" @@ -559,7 +558,7 @@ "> > + b = data->b[class];\n" "> > + R = data->R[class];\n" "> > +\n" - "> > + if (m == 0)\n" + "> > + if (m = 0)\n" "> > + return 0;\n" "> > +\n" "> > + /* X = 1/m * (Y * 10^-R - b) */\n" @@ -567,7 +566,7 @@ "> > + b *= 1000; /* subtract milli-units */\n" "> > +\n" "> > + /* scale result to micro-units for power sensors */\n" - "> > + if (class == PSC_POWER) {\n" + "> > + if (class = PSC_POWER) {\n" "> > + R += 3;\n" "> > + b *= 1000;\n" "> > + }\n" @@ -607,7 +606,7 @@ "> > + bool negative = false;\n" "> > +\n" "> > + /* simple case */\n" - "> > + if (val == 0)\n" + "> > + if (val = 0)\n" "> > + return 0;\n" "> > +\n" "> > + if (val < 0) {\n" @@ -616,7 +615,7 @@ "> > + }\n" "> > +\n" "> > + /* Power is in uW. Convert to mW before converting. */\n" - "> > + if (class == PSC_POWER)\n" + "> > + if (class = PSC_POWER)\n" "> > + val = DIV_ROUND_CLOSEST(val, 1000L);\n" "> > +\n" "> > + /* Reduce large mantissa until it fits into 10 bit */\n" @@ -655,7 +654,7 @@ "> > + R = data->R[class];\n" "> > +\n" "> > + /* Power is in uW. Adjust R. */\n" - "> > + if (class == PSC_POWER)\n" + "> > + if (class = PSC_POWER)\n" "> > + R -= 3;\n" "> > +\n" "> > + /* Calculate Y = (m * X + b) * 10^R */\n" @@ -960,7 +959,7 @@ "> > + data->R[i] = pmbus_config[data->type].R[i];\n" "> > + }\n" "> > +\n" - "> > + if (data->type == pmbus) {\n" + "> > + if (data->type = pmbus) {\n" "> > + /*\n" "> > + * We could try to determine supported options here.\n" "> > + * However, it appears that hardly any chips support\n" @@ -1681,6 +1680,11 @@ "> > +#define PB_CML_FAULT_INVALID_COMMAND (1<<7)\n" "> > +\n" "> > +#endif /* PB_H */\n" - > + "> \n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -05c9b07fd7281a1aa7b6d77fa73da6fd1cdbcc22066407daf82cafee69fdc90f +e08baafa68f7a2d620d687a69e81f96bd898c5b560ef14088d4f1885bbbb0de5
diff --git a/a/1.txt b/N2/1.txt index 032f584..1ef6e80 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -15,7 +15,7 @@ Comments inline. And thanks a lot for your time! Guenter > -> > Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> +> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> > > --- > > drivers/hwmon/Kconfig | 12 + > > drivers/hwmon/Makefile | 1 + diff --git a/a/content_digest b/N2/content_digest index 1e493e9..860a8aa 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,26 +1,25 @@ "ref\01277762214-15155-1-git-send-email-guenter.roeck@ericsson.com\0" "ref\01277762214-15155-3-git-send-email-guenter.roeck@ericsson.com\0" "ref\04C29F7EB.6020602@jic23.retrosnub.co.uk\0" - "ref\04C29F7EB.6020602-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org\0" - "From\0Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>\0" + "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" "Subject\0Re: [PATCH/RFC 2/4] hwmon: PMBus device driver\0" "Date\0Tue, 29 Jun 2010 07:31:28 -0700\0" - "To\0Jonathan Cameron <kernel-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org>\0" - "Cc\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" - Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> - Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> - Ira W. Snyder <iws-lulEs6mt1IksTUYHLfqkUA@public.gmane.org> - Darrick J. Wong <djwong-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> - Ben Dooks (embedded platforms) <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> - Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> - Crane Cai <crane.cai-5C7GfCeVMHo@public.gmane.org> - Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> - Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Jonathan Cameron <kernel@jic23.retrosnub.co.uk>\0" + "Cc\0Jean Delvare <khali@linux-fr.org>" + Randy Dunlap <rdunlap@xenotime.net> + Andrew Morton <akpm@linux-foundation.org> + Ira W. Snyder <iws@ovro.caltech.edu> + Darrick J. Wong <djwong@us.ibm.com> + Ben Dooks (embedded platforms) <ben-linux@fluff.org> + Hans de Goede <hdegoede@redhat.com> + Mark Brown <broonie@opensource.wolfsonmicro.com> + Samuel Ortiz <sameo@linux.intel.com> + Crane Cai <crane.cai@amd.com> + Linus Walleij <linus.walleij@stericsson.com> + Ralf Baechle <ralf@linux-mips.org> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-i2c@vger.kernel.org <linux-i2c@vger.kernel.org>\0" "\00:1\0" "b\0" "On Tue, Jun 29, 2010 at 09:40:59AM -0400, Jonathan Cameron wrote:\n" @@ -40,7 +39,7 @@ "Guenter\n" "\n" "> \n" - "> > Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>\n" + "> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>\n" "> > ---\n" "> > drivers/hwmon/Kconfig | 12 +\n" "> > drivers/hwmon/Makefile | 1 +\n" @@ -1683,4 +1682,4 @@ "> > +#endif /* PB_H */\n" > -05c9b07fd7281a1aa7b6d77fa73da6fd1cdbcc22066407daf82cafee69fdc90f +e23b1f642afb71676883d2d0be352b23d704ab33b55b0e74d6936ab91755a51f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.