From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org
Cc: quintela@redhat.com, chrisw@redhat.com, alex.williamson@redhat.com
Subject: [PATCH] device-assignment: Clear assigned_dev irq type
Date: Tue, 29 Jun 2010 11:51:54 -0600 [thread overview]
Message-ID: <20100629175103.5078.11134.stgit@localhost.localdomain> (raw)
Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
but what we really want is to clear assigned_dev->irq_requested_type.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Found-by: Juan Quintela <quintela@redhat.com>
---
hw/device-assignment.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 585162b..48ac73c 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
if (r && r != -ENXIO)
perror("assigned_dev_update_msi: deassign irq");
- assigned_irq_data.flags = 0;
+ assigned_dev->irq_requested_type = 0;
}
if (ctrl_byte & PCI_MSI_FLAGS_ENABLE) {
@@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)
if (r && r != -ENXIO)
perror("assigned_dev_update_msix: deassign irq");
- assigned_irq_data.flags = 0;
+ assigned_dev->irq_requested_type = 0;
}
if (*ctrl_word & PCI_MSIX_ENABLE) {
next reply other threads:[~2010-06-29 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 17:51 Alex Williamson [this message]
2010-06-29 17:55 ` [PATCH] device-assignment: Clear assigned_dev irq type Chris Wright
2010-06-29 18:13 ` Juan Quintela
2010-06-30 16:59 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629175103.5078.11134.stgit@localhost.localdomain \
--to=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.