From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features Date: Wed, 30 Jun 2010 09:17:26 +0300 Message-ID: <20100630061726.GQ2822@atomide.com> References: <20100629113229.16008.2931.stgit@baageli.muru.com> <20100629114738.16008.62006.stgit@baageli.muru.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:54616 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994Ab0F3GRV (ORCPT ); Wed, 30 Jun 2010 02:17:21 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" * Shilimkar, Santosh [100629 17:40]: > > > > > With your series OMAP4 build breaks because of PM and SMP dependencies. > > To ensure that build doesn't break on OMAP4, I needed below change. With > > This change I tried your series and it boots OK on OMAP4430 SDP Hmm the build does not break for me? > Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both boots OK. > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 84fecd0..f48f275 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL > > default y > > select AEABI > > select REGULATOR > > - select PM > > - select PM_RUNTIME > > + select PM if !ARCH_OMAP4 > > + select PM_RUNTIME if !ARCH_OMAP4 > > select VFP > > select NEON if ARCH_OMAP3 || ARCH_OMAP4 > > select SERIAL_8250 Let's rather fix whatever the issue is for booting (or building?) omap4 with CONFIG_PM and CONFIG_PM_RUNTIME. If we can't implement PM yet for omap4, we can just return early if cpu_is_omap44xx. CONFIG_SMP we can't enable as that requires various ARM changes to work on unicore systems. But hopefully we can enable that too at some point with select SMP if ARCH_OMAP4. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 30 Jun 2010 09:17:26 +0300 Subject: [PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features In-Reply-To: References: <20100629113229.16008.2931.stgit@baageli.muru.com> <20100629114738.16008.62006.stgit@baageli.muru.com> Message-ID: <20100630061726.GQ2822@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Shilimkar, Santosh [100629 17:40]: > > > > > With your series OMAP4 build breaks because of PM and SMP dependencies. > > To ensure that build doesn't break on OMAP4, I needed below change. With > > This change I tried your series and it boots OK on OMAP4430 SDP Hmm the build does not break for me? > Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both boots OK. > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 84fecd0..f48f275 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL > > default y > > select AEABI > > select REGULATOR > > - select PM > > - select PM_RUNTIME > > + select PM if !ARCH_OMAP4 > > + select PM_RUNTIME if !ARCH_OMAP4 > > select VFP > > select NEON if ARCH_OMAP3 || ARCH_OMAP4 > > select SERIAL_8250 Let's rather fix whatever the issue is for booting (or building?) omap4 with CONFIG_PM and CONFIG_PM_RUNTIME. If we can't implement PM yet for omap4, we can just return early if cpu_is_omap44xx. CONFIG_SMP we can't enable as that requires various ARM changes to work on unicore systems. But hopefully we can enable that too at some point with select SMP if ARCH_OMAP4. Regards, Tony