From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v2] ASoC: ak4642: Add Digital Playback Volume control
Date: Wed, 30 Jun 2010 13:59:55 +0100 [thread overview]
Message-ID: <20100630125955.GC3634@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <w3p1vbq8fod.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jun 29, 2010 at 04:24:19PM +0900, Kuninori Morimoto wrote:
> + /* default volume */
> + ak4642_write(codec, L_DVC, 0x28);
> + ak4642_write(codec, R_DVC, 0x28);
> +
Unless there is a particular reason to do so we should trust the chip
default volume. A volume which is sensible in one appolication may not
be appropriate in another (eg, using a different output path or with an
external amplifier).
prev parent reply other threads:[~2010-06-30 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 7:24 [PATCH v2] ASoC: ak4642: Add Digital Playback Volume control Kuninori Morimoto
2010-06-30 12:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630125955.GC3634@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.