Re: [PATCH] x86 oprofile: use rdmsrl/wrmsrl

[Christoph Egger <Christoph.Egger@amd.com>]

On Wednesday 30 June 2010 12:19:09 Keir Fraser wrote:
> On 30/06/2010 11:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote:
> >> How many more of these patches do you have up your sleeve?
> >
> > Depends on how small/large the chunks should/may be.
> > My intention is to remove duplicated rdmsr/wrmsr functions
> > and make rdmsr usable as a real C function.
>
> It's a lot of effort for questionable value isn't it. And many of your
> patches so far have contained bugs, and in some cases decreased code
> readability by needing to manually merge/split values to be able to make
> use of rdmsrl/wrmsrl, so it's not like it's even strictly improving the
> code. Frankly, it smells like busy work.

Yes, you're right. Work like this is not funny and error-prone
(you can look over it many times, test it many times and still bugs
sit in there), hence the high number of small patches so that other
people look at it and make bisecting easier.
Whoever is doing such work always risks to get the head chopped off
for the breakages.

The parts decreasing code readability should actually be rewritten
but this is beyond of my intention.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632