From: Steffen Klassert <steffen.klassert@secunet.com>
To: Dan Kruchinin <kruchinin@altell.ru>
Cc: LKML <linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.hengli.com.au>
Subject: Re: [PATCH 1/2] padata: Separate cpumasks for cb_cpus and parallel workers
Date: Wed, 30 Jun 2010 15:03:15 +0200 [thread overview]
Message-ID: <20100630130315.GE10072@secunet.com> (raw)
In-Reply-To: <20100629203415.01c953e4@leibniz>
On Tue, Jun 29, 2010 at 08:34:15PM +0400, Dan Kruchinin wrote:
> 1) Two separate cpumasks for parallel and serial workers
> 2) padata_alloc does not takes cpumask as its argument, instead
> it uses a default one. __padata_alloc takes two cpumasks as its
> arguments: one for parallel workers and another one for serial.
> 3) I made padata_cpu_hash a public function to reduce code size(in
> several places in pcrypt.c there is near the same code(for getting cpu
> hash) as in padata_cpu_hash)
>
Plead keep padata_cpu_hash() static to padata. If this becomes
part of the padata API it's not that easy to change it anymore.
You could add a similar function to pcrypt and use this function
there wehenver it's needed.
prev parent reply other threads:[~2010-06-30 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 16:34 [PATCH 1/2] padata: Separate cpumasks for cb_cpus and parallel workers Dan Kruchinin
2010-06-30 11:52 ` Steffen Klassert
2010-06-30 13:03 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630130315.GE10072@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kruchinin@altell.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.