From: Andrew Morton <akpm@linux-foundation.org>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Kyungmin Park <kmpark@infradead.org>,
Madhusudhan Chikkature <madhu.cr@ti.com>,
linux-mmc Mailing List <linux-mmc@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 4/5] block: Add secure discard
Date: Wed, 30 Jun 2010 15:09:47 -0700 [thread overview]
Message-ID: <20100630150947.d53200ac.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100624084423.25444.1011.sendpatchset@ahunter-work.research.nokia.com>
On Thu, 24 Jun 2010 11:44:23 +0300
Adrian Hunter <adrian.hunter@nokia.com> wrote:
> >From b25b9a499f255ee5999c219525d82ef40382318c Mon Sep 17 00:00:00 2001
> From: Adrian Hunter <adrian.hunter@nokia.com>
> Date: Wed, 23 Jun 2010 15:41:38 +0300
> Subject: [PATCH 4/5] block: Add secure discard
>
> Secure discard is the same as discard except that all copies
> of the discarded sectors (perhaps created by garbage collection)
> must also be erased.
That's not an awfully informative changelog.
>From a quick peek at the code it seems that you took your earlier
design sketch:
On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote:
> Needs a bio flag, a request flag, setup the request flag based on the
> bio flag, prevent merging secure and non-secure discards, prevent drivers
> doing non-secure discards for secure discards.
>
> Seems like a lot of little changes for something that no one wants.
> Shouldn't it wait for someone to need it first?
and changed your mind and implemented it.
Is that a correct interpretation?
next prev parent reply other threads:[~2010-06-30 22:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 8:43 [PATCH V3 0/5] Add MMC erase and secure erase V3 Adrian Hunter
2010-06-24 8:44 ` [PATCH V3 1/5] mmc: Add erase, secure erase, trim and secure trim operations Adrian Hunter
2010-06-30 22:21 ` Andrew Morton
2010-07-01 10:49 ` Adrian Hunter
2010-06-24 8:44 ` [PATCH V3 2/5] mmc_block: Add discard support Adrian Hunter
2010-06-24 8:44 ` [PATCH V3 3/5] omap_hsmmc: Add erase capability Adrian Hunter
2010-06-24 8:44 ` [PATCH V3 4/5] block: Add secure discard Adrian Hunter
2010-06-30 22:09 ` Andrew Morton [this message]
2010-07-01 10:18 ` Adrian Hunter
2010-06-24 8:44 ` [PATCH V3 5/5] mmc_block: Add support for " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630150947.d53200ac.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adrian.hunter@nokia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=madhu.cr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.