From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Date: Wed, 30 Jun 2010 21:32:18 +0000 Subject: Re: [PATCH 4/4] x86: OLPC: add OLPC device-tree support Message-Id: <20100630173218.2bdd18d4@dev.queued.net> List-Id: References: <20100628215407.2017bf2f@debian> <20100628220058.19e8f143@debian> <20100629102339.5e8a30b6@dev.queued.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Grant Likely Cc: pgf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mitch Bradley , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org On Wed, 30 Jun 2010 15:13:26 -0600 Grant Likely wrote: > On Tue, Jun 29, 2010 at 8:23 AM, Andres Salomon > wrote: > > On Tue, 29 Jun 2010 01:12:36 -0700 > > Grant Likely wrote: [...] > >> > +extern void prom_build_devicetree(void); > >> > + > >> > +extern void *prom_early_alloc(unsigned long size); > >> > + > >> > +extern char *prom_firstprop(phandle node, char *buf); > >> > +extern char *prom_nextprop(phandle node, const char *prev, char > >> > *buf); +extern int prom_getproplen(phandle node, const char > >> > *prop); +extern int prom_getproperty(phandle node, const char > >> > *prop, > >> > +                            char *buffer, int bufsize); > >> > +extern phandle prom_getchild(phandle node); > >> > +extern phandle prom_getsibling(phandle node); > >> > + > >> > +#endif /* __KERNEL__ */ > >> > +#endif /* _X86_PROM_OLPC_H */ > >> > diff --git a/arch/x86/include/asm/prom.h > >> > b/arch/x86/include/asm/prom.h new file mode 100644 > >> > index 0000000..7b561b2 > >> > --- /dev/null > >> > +++ b/arch/x86/include/asm/prom.h > >> > @@ -0,0 +1,5 @@ > >> > +#ifdef CONFIG_OLPC_OPENFIRMWARE > >> > +# include > >> > +#else > >> > +# error "No OFW prom defined for x86!" > >> > +#endif > >> > >> Personally, I wouldn't bother with the header file redirection. > > > > The reason for the header file redirection is because this is > > OLPC-only; the x86 folks don't want me claiming this to be the One > > True x86 OFW. > > However, the #ifdef/#elseif/#else/#endif approach also makes the > assumption that only one kind of OFW will be supported by any given > kernel. Or for that matter, both OFW and the flattened tree also > become mutually exclusive due to the default behaviour override. > > Besides, aren't the function declarations just the interface defined > by the prom extraction code? Is there any need to #ifdef that API? I > would think those function prototypes should be defined by the header > for the prom extraction code. Mm, both are good points; I suppose for now it doesn't hurt to lose the #ifdefs, and deal w/ additional x86 proms support if it comes up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315Ab0F3Vc2 (ORCPT ); Wed, 30 Jun 2010 17:32:28 -0400 Received: from LUNGE.MIT.EDU ([18.54.1.69]:54291 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177Ab0F3VcY convert rfc822-to-8bit (ORCPT ); Wed, 30 Jun 2010 17:32:24 -0400 Date: Wed, 30 Jun 2010 17:32:18 -0400 From: Andres Salomon To: Grant Likely Cc: devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, cjb@laptop.org, Mitch Bradley , pgf@laptop.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH 4/4] x86: OLPC: add OLPC device-tree support Message-ID: <20100630173218.2bdd18d4@dev.queued.net> In-Reply-To: References: <20100628215407.2017bf2f@debian> <20100628220058.19e8f143@debian> <20100629102339.5e8a30b6@dev.queued.net> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.12.12; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jun 2010 15:13:26 -0600 Grant Likely wrote: > On Tue, Jun 29, 2010 at 8:23 AM, Andres Salomon > wrote: > > On Tue, 29 Jun 2010 01:12:36 -0700 > > Grant Likely wrote: [...] > >> > +extern void prom_build_devicetree(void); > >> > + > >> > +extern void *prom_early_alloc(unsigned long size); > >> > + > >> > +extern char *prom_firstprop(phandle node, char *buf); > >> > +extern char *prom_nextprop(phandle node, const char *prev, char > >> > *buf); +extern int prom_getproplen(phandle node, const char > >> > *prop); +extern int prom_getproperty(phandle node, const char > >> > *prop, > >> > +                            char *buffer, int bufsize); > >> > +extern phandle prom_getchild(phandle node); > >> > +extern phandle prom_getsibling(phandle node); > >> > + > >> > +#endif /* __KERNEL__ */ > >> > +#endif /* _X86_PROM_OLPC_H */ > >> > diff --git a/arch/x86/include/asm/prom.h > >> > b/arch/x86/include/asm/prom.h new file mode 100644 > >> > index 0000000..7b561b2 > >> > --- /dev/null > >> > +++ b/arch/x86/include/asm/prom.h > >> > @@ -0,0 +1,5 @@ > >> > +#ifdef CONFIG_OLPC_OPENFIRMWARE > >> > +# include > >> > +#else > >> > +# error "No OFW prom defined for x86!" > >> > +#endif > >> > >> Personally, I wouldn't bother with the header file redirection. > > > > The reason for the header file redirection is because this is > > OLPC-only; the x86 folks don't want me claiming this to be the One > > True x86 OFW. > > However, the #ifdef/#elseif/#else/#endif approach also makes the > assumption that only one kind of OFW will be supported by any given > kernel. Or for that matter, both OFW and the flattened tree also > become mutually exclusive due to the default behaviour override. > > Besides, aren't the function declarations just the interface defined > by the prom extraction code? Is there any need to #ifdef that API? I > would think those function prototypes should be defined by the header > for the prom extraction code. Mm, both are good points; I suppose for now it doesn't hurt to lose the #ifdefs, and deal w/ additional x86 proms support if it comes up. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Subject: Re: [PATCH 4/4] x86: OLPC: add OLPC device-tree support Date: Wed, 30 Jun 2010 17:32:18 -0400 Message-ID: <20100630173218.2bdd18d4@dev.queued.net> References: <20100628215407.2017bf2f@debian> <20100628220058.19e8f143@debian> <20100629102339.5e8a30b6@dev.queued.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: pgf-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mitch Bradley , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org List-Id: devicetree@vger.kernel.org T24gV2VkLCAzMCBKdW4gMjAxMCAxNToxMzoyNiAtMDYwMApHcmFudCBMaWtlbHkgPGdyYW50Lmxp a2VseUBzZWNyZXRsYWIuY2E+IHdyb3RlOgoKPiBPbiBUdWUsIEp1biAyOSwgMjAxMCBhdCA4OjIz IEFNLCBBbmRyZXMgU2Fsb21vbiA8ZGlsaW5nZXJAcXVldWVkLm5ldD4KPiB3cm90ZToKPiA+IE9u IFR1ZSwgMjkgSnVuIDIwMTAgMDE6MTI6MzYgLTA3MDAKPiA+IEdyYW50IExpa2VseSA8Z3JhbnQu bGlrZWx5QHNlY3JldGxhYi5jYT4gd3JvdGU6ClsuLi5dCj4gPj4gPiArZXh0ZXJuIHZvaWQgcHJv bV9idWlsZF9kZXZpY2V0cmVlKHZvaWQpOwo+ID4+ID4gKwo+ID4+ID4gK2V4dGVybiB2b2lkICpw cm9tX2Vhcmx5X2FsbG9jKHVuc2lnbmVkIGxvbmcgc2l6ZSk7Cj4gPj4gPiArCj4gPj4gPiArZXh0 ZXJuIGNoYXIgKnByb21fZmlyc3Rwcm9wKHBoYW5kbGUgbm9kZSwgY2hhciAqYnVmKTsKPiA+PiA+ ICtleHRlcm4gY2hhciAqcHJvbV9uZXh0cHJvcChwaGFuZGxlIG5vZGUsIGNvbnN0IGNoYXIgKnBy ZXYsIGNoYXIKPiA+PiA+ICpidWYpOyArZXh0ZXJuIGludCBwcm9tX2dldHByb3BsZW4ocGhhbmRs ZSBub2RlLCBjb25zdCBjaGFyCj4gPj4gPiAqcHJvcCk7ICtleHRlcm4gaW50IHByb21fZ2V0cHJv cGVydHkocGhhbmRsZSBub2RlLCBjb25zdCBjaGFyCj4gPj4gPiAqcHJvcCwKPiA+PiA+ICsgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBjaGFyICpidWZmZXIsIGludCBi dWZzaXplKTsKPiA+PiA+ICtleHRlcm4gcGhhbmRsZSBwcm9tX2dldGNoaWxkKHBoYW5kbGUgbm9k ZSk7Cj4gPj4gPiArZXh0ZXJuIHBoYW5kbGUgcHJvbV9nZXRzaWJsaW5nKHBoYW5kbGUgbm9kZSk7 Cj4gPj4gPiArCj4gPj4gPiArI2VuZGlmIC8qIF9fS0VSTkVMX18gKi8KPiA+PiA+ICsjZW5kaWYg LyogX1g4Nl9QUk9NX09MUENfSCAqLwo+ID4+ID4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3Byb20uaAo+ID4+ID4gYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9wcm9tLmggbmV3IGZp bGUgbW9kZSAxMDA2NDQKPiA+PiA+IGluZGV4IDAwMDAwMDAuLjdiNTYxYjIKPiA+PiA+IC0tLSAv ZGV2L251bGwKPiA+PiA+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3Byb20uaAo+ID4+ID4g QEAgLTAsMCArMSw1IEBACj4gPj4gPiArI2lmZGVmIENPTkZJR19PTFBDX09QRU5GSVJNV0FSRQo+ ID4+ID4gKyMgaW5jbHVkZSA8YXNtL29scGNfcHJvbS5oPgo+ID4+ID4gKyNlbHNlCj4gPj4gPiAr IyBlcnJvciAiTm8gT0ZXIHByb20gZGVmaW5lZCBmb3IgeDg2ISIKPiA+PiA+ICsjZW5kaWYKPiA+ Pgo+ID4+IFBlcnNvbmFsbHksIEkgd291bGRuJ3QgYm90aGVyIHdpdGggdGhlIGhlYWRlciBmaWxl IHJlZGlyZWN0aW9uLgo+ID4KPiA+IFRoZSByZWFzb24gZm9yIHRoZSBoZWFkZXIgZmlsZSByZWRp cmVjdGlvbiBpcyBiZWNhdXNlIHRoaXMgaXMKPiA+IE9MUEMtb25seTsgdGhlIHg4NiBmb2xrcyBk b24ndCB3YW50IG1lIGNsYWltaW5nIHRoaXMgdG8gYmUgdGhlIE9uZQo+ID4gVHJ1ZSB4ODYgT0ZX Lgo+IAo+IEhvd2V2ZXIsIHRoZSAjaWZkZWYvI2Vsc2VpZi8jZWxzZS8jZW5kaWYgYXBwcm9hY2gg YWxzbyBtYWtlcyB0aGUKPiBhc3N1bXB0aW9uIHRoYXQgb25seSBvbmUga2luZCBvZiBPRlcgd2ls bCBiZSBzdXBwb3J0ZWQgYnkgYW55IGdpdmVuCj4ga2VybmVsLiAgT3IgZm9yIHRoYXQgbWF0dGVy LCBib3RoIE9GVyBhbmQgdGhlIGZsYXR0ZW5lZCB0cmVlIGFsc28KPiBiZWNvbWUgbXV0dWFsbHkg ZXhjbHVzaXZlIGR1ZSB0byB0aGUgZGVmYXVsdCBiZWhhdmlvdXIgb3ZlcnJpZGUuCj4gCj4gQmVz aWRlcywgYXJlbid0IHRoZSBmdW5jdGlvbiBkZWNsYXJhdGlvbnMganVzdCB0aGUgaW50ZXJmYWNl IGRlZmluZWQKPiBieSB0aGUgcHJvbSBleHRyYWN0aW9uIGNvZGU/ICBJcyB0aGVyZSBhbnkgbmVl ZCB0byAjaWZkZWYgdGhhdCBBUEk/ICBJCj4gd291bGQgdGhpbmsgdGhvc2UgZnVuY3Rpb24gcHJv dG90eXBlcyBzaG91bGQgYmUgZGVmaW5lZCBieSB0aGUgaGVhZGVyCj4gZm9yIHRoZSBwcm9tIGV4 dHJhY3Rpb24gY29kZS4KCk1tLCBib3RoIGFyZSBnb29kIHBvaW50czsgSSBzdXBwb3NlIGZvciBu b3cgaXQgZG9lc24ndCBodXJ0IHRvIGxvc2UgdGhlCiNpZmRlZnMsIGFuZCBkZWFsIHcvIGFkZGl0 aW9uYWwgeDg2IHByb21zIHN1cHBvcnQgaWYgaXQgY29tZXMgdXAuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGlu ZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMu b3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK