From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] OMAP4: Add support for PWM LED Date: Thu, 1 Jul 2010 15:19:05 +0300 Message-ID: <20100701121905.GN2822@atomide.com> References: <17175.10.24.255.18.1277906683.squirrel@dbdmail.itg.ti.com> <20100701103727.GJ2822@atomide.com> <028701cb1917$5313cd60$LocalHost@wipblrx0099946> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:51758 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755255Ab0GAMSz (ORCPT ); Thu, 1 Jul 2010 08:18:55 -0400 Content-Disposition: inline In-Reply-To: <028701cb1917$5313cd60$LocalHost@wipblrx0099946> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Hemanth V Cc: linux-omap@vger.kernel.org * Hemanth V [100701 15:11]: > ----- Original Message ----- From: "Tony Lindgren" > > To: "Hemanth V" > Cc: > Sent: Thursday, July 01, 2010 4:07 PM > Subject: Re: [PATCH 2/2] OMAP4: Add support for PWM LED > > > >* Hemanth V [100630 17:12]: > >>From 713727188b99465341767eedaa42004862261211 Mon Sep 17 00:00:00 2001 > >>From: Hemanth V > >>Date: Wed, 30 Jun 2010 18:16:33 +0530 > >>Subject: [PATCH] OMAP4: Add support for PWM LED > >> > >>TWL6030 supports PWM (Pulse Width Modulator) which is used > >>to control charging LED. This allows for controlling brightness > >>This patch implements the APIs needed by leds-pwm driver. > > > > > > > >>--- /dev/null > >>+++ b/arch/arm/mach-omap2/twl6030_pwm.c > >>@@ -0,0 +1,168 @@ > >>+/* > >>+ * twl6030_pwm.c > >>+ * Driver for PHOENIX (TWL6030) Pulse Width Modulator > > > >This should go to somewhere under drivers instead of > >arch/arm/mach-omap2. > > Tony, since PWM is specific to each platform, they are typically > under platform folder. Some examples below > > arch/arm/plat-mxc/pwm.c > arch/arm/plat-pxa/pwm.c > arch/arm/plat-samsung/pwm.c But this is related to an external PM chip that can be potentially used for other chips than omaps. Tony