Re: [PATCHv3 1/3] mfd: add STMPE I/O Expander support

[Luotao Fu <l.fu@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2350 bytes --]

Hi Rabin,

On Thu, Jul 01, 2010 at 05:30:46PM +0530, Rabin Vincent wrote:
> Add support for the STMPE family of I/O Expanders from
> STMicroelectronics.  These devices include upto 24 gpios and a varying
> selection of blocks, including PWM, keypad, and touchscreen controllers.
> This patch adds the MFD core.
> 
> [l.fu@pengutronix.de: fix stmpe811 enable hook]
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
> ---
> 
> CHANGELOG (for the whole set)
> 
> v2 -> v3:
>   - Locking fixes
>   - Expanded Kconfig description
>   - Moved stmpe-devices.c content into stmpe.c
>   - Moved debug ifdefs to header
>   - Folded in Luotao Fu's one-liner fix for STMPE811 enable
>   - Folded in Luotao Fu's one-liner fix for stmpe-gpio input
>     direction
> 
> v1 -> v2
>   - Variant data to support other STMPE* variants
>   - Enable/disable API
>   - GPIO setup/remove callbacks
>   - pdata made optional for GPIO
>   - Platform specifies which blocks it wants to use
>   - IRQ invert polarity option
>   - STMPE811 support (needs testing)
> 
>  drivers/mfd/Kconfig       |   23 ++
>  drivers/mfd/Makefile      |    1 +
>  drivers/mfd/stmpe.c       |  915 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/mfd/stmpe.h       |  176 +++++++++
>  include/linux/mfd/stmpe.h |  154 ++++++++
>  5 files changed, 1269 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mfd/stmpe.c
>  create mode 100644 drivers/mfd/stmpe.h
>  create mode 100644 include/linux/mfd/stmpe.h
> 

It might be great if you could also fold the patch
35df3fb7291f7b0281f0fce27a4e9cde0ea0b32f
mfd/stmpexxx: add touchscreen platform data
https://patchwork.kernel.org/patch/107833/
into this serie too. It simply makes little sense that the ts platform data
should be added in a separate patch, while keypad and gpio platformdata
stuffes are included in this patch.

otherwise:
Acked-by: Luotao Fu <l.fu@pengutronix.de>

cheers
Luotao Fu
-- 
Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]