From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1 of 1] mini-os: PV fronted MUST be in
	XenbusStateConnected not XenbusStateInitialized during init
Date: Thu, 1 Jul 2010 10:05:49 -0400
Message-ID: <20100701140549.GA31947@phenom.dumpdata.com>
References: <patchbomb.1277908240@phenom.dumpdata.com>
	<76e7d0258f65e4ab1b10.1277908241@phenom.dumpdata.com>
	<alpine.DEB.2.00.1007011114290.30135@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1007011114290.30135@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Keir@acsinet12.oracle.com, Fraser <Keir.Fraser@eu.citrix.com>, Anthony.Perard@citrix.com, Gerd Hoffmann <kraxel@redhat.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Jul 01, 2010 at 12:32:15PM +0100, Stefano Stabellini wrote:
> Thank you for the patch Konrad.
> 
> I think this fix shows us that 805ed3b20492d2f4bb465bfda65cedd286e23209
> was the wrong fix:
> 
> commit 805ed3b20492d2f4bb465bfda65cedd286e23209
> Author: Ian Jackson <ian.jackson@eu.citrix.com>
> Date:   Fri May 21 15:46:55 2010 +0100
> 
>     Wait for frontend state Connected before connecting the backend
> 
>     The frontend of the framebuffer set a value
>     (request-abs-pointer) and go
>     to the state Connected.  The backend must read this value
>     only when the
>     frontend has the state Connected.
> 
> 
> The problem was that the backend can be sure that the linux xenfb
> frontend wrote request-abs-pointer only after the frontend state is
> Connected.
> In order to do that properly we need a new hook in qemu xen_backend: we
> should probably rename the current connect hook to initialise and create
> a new connect hook that would be implemented by xenfb to read
> request-abs-pointer.

Uhh. How about a compromise. Lets put this hac^H^H^Hpatch in, and when the QEMU
fix is ready, yank this out and also the c/s 21260:

"mini-os: Revert 21106:b20f897d6010 "Fix xenbus initialisation"

Jeremy Fitzhardinge (jeremy@goop.org) reports that this fixes
HVM+stubdom."

which was fixing the same exact problem I did, but on the stubdomain
side?