From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] x86: fix an off-by-one pirq range check
Date: Thu, 1 Jul 2010 12:19:45 -0400
Message-ID: <20100701161945.GB4089@phenom.dumpdata.com>
References: <4C2B02460200007800008B83@vpn.id2.novell.com>
	<20100630161641.GE5100@phenom.dumpdata.com>
	<4C2C5F7B0200007800008FE9@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4C2C5F7B0200007800008FE9@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Jul 01, 2010 at 08:27:23AM +0100, Jan Beulich wrote:
> >>> On 30.06.10 at 18:16, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Wed, Jun 30, 2010 at 07:37:26AM +0100, Jan Beulich wrote:
> >> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > 
> > Won't that make PV guest with only one IRQ passed through unable to ACK it?
> > (and if the IRQ is not shared that is).
> 
> Why would you think so? In such a case, nr_pirqs would be 1, and the
> only permitted pirq would be 0. All other places do the range checks
> correctly, just this one would let through an out of bounds number.

Excellent. Thanks for the answer.