From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit master 1/1] Makefile.package.in: allow packages to override download step
Date: Thu, 1 Jul 2010 18:04:47 +0200 [thread overview]
Message-ID: <20100701180447.3477a6fa@surf> (raw)
In-Reply-To: <20100701153712.9DCD6821E8@busybox.osuosl.org>
Hello,
On Thu, 1 Jul 2010 17:33:29 +0200
Peter Korsgaard <jacmet@sunsite.dk> wrote:
> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> index 16ce16a..c476de9 100644
> --- a/package/Makefile.package.in
> +++ b/package/Makefile.package.in
> @@ -292,7 +292,7 @@ $(2)_TARGET_BUILD =
> $$($(2)_DIR)/.stamp_built $(2)_TARGET_CONFIGURE =
> $$($(2)_DIR)/.stamp_configured $(2)_TARGET_PATCH =
> $$($(2)_DIR)/.stamp_patched $(2)_TARGET_EXTRACT =
> $$($(2)_DIR)/.stamp_extracted -$(2)_TARGET_SOURCE =
> $$($(2)_DIR)/.stamp_downloaded +$(2)_TARGET_SOURCE ?=
> $$($(2)_DIR)/.stamp_downloaded $(2)_TARGET_UNINSTALL =
> $$($(2)_DIR)/.stamp_uninstalled $(2)_TARGET_CLEAN =
> $$($(2)_DIR)/.stamp_cleaned $(2)_TARGET_DIRCLEAN =
> $$($(2)_DIR)/.stamp_dircleaned
As said on IRC, I'm sorry but I don't think I really like this.
We already have a mechanism to override steps in Makefile.autotools.in.
I'd prefer to see if we can rely on a similar mechanism rather than
doing this.
In the future, is it possible to discuss such infrastructure changes on
the list beforehand ?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-07-01 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 15:33 [Buildroot] [git commit master 1/1] Makefile.package.in: allow packages to override download step Peter Korsgaard
2010-07-01 16:04 ` Thomas Petazzoni [this message]
2010-07-07 20:21 ` Luca Ceresoli
2010-07-08 7:30 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2010-07-08 10:11 Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701180447.3477a6fa@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.