From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Date: Thu, 01 Jul 2010 18:27:24 +0000 Subject: Re: [PATCH 10/25] scsi/sg: remove casts from void* Message-Id: <20100701182724.GA22466@shinshilla> List-Id: References: <1277990204-22157-1-git-send-email-segooon@gmail.com> <20100701173805.GW19184@bicker> In-Reply-To: <20100701173805.GW19184@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Kernel Janitors , Doug Gilbert , "James E.J. Bottomley" , Andrew On Thu, Jul 01, 2010 at 19:38 +0200, Dan Carpenter wrote: > On Thu, Jul 01, 2010 at 05:16:43PM +0400, Kulikov Vasiliy wrote: > > - Sg_fd *sfp; > > + Sg_fd *sfp = filp->private_data; > ^^^^^^^^^^^^^^^^^^ > Dereferenced here. > > > unsigned long req_sz, len, sa; > > Sg_scatter_hold *rsv_schp; > > int k, length; > > > > - if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data))) > > + if ((!filp) || (!vma) || !(sfp)) > ^^^^^ > > Checked here. Oops, I've loosed it... The problem is that this driver is not even compileable. Patch v2 coming soon) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Subject: Re: [PATCH 10/25] scsi/sg: remove casts from void* Date: Thu, 1 Jul 2010 22:27:24 +0400 Message-ID: <20100701182724.GA22466@shinshilla> References: <1277990204-22157-1-git-send-email-segooon@gmail.com> <20100701173805.GW19184@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:59253 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758276Ab0GAS1c (ORCPT ); Thu, 1 Jul 2010 14:27:32 -0400 Content-Disposition: inline In-Reply-To: <20100701173805.GW19184@bicker> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter , Kernel Janitors , Doug Gilbert , "James E.J. Bottomley" , Andrew On Thu, Jul 01, 2010 at 19:38 +0200, Dan Carpenter wrote: > On Thu, Jul 01, 2010 at 05:16:43PM +0400, Kulikov Vasiliy wrote: > > - Sg_fd *sfp; > > + Sg_fd *sfp = filp->private_data; > ^^^^^^^^^^^^^^^^^^ > Dereferenced here. > > > unsigned long req_sz, len, sa; > > Sg_scatter_hold *rsv_schp; > > int k, length; > > > > - if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data))) > > + if ((!filp) || (!vma) || !(sfp)) > ^^^^^ > > Checked here. Oops, I've loosed it... The problem is that this driver is not even compileable. Patch v2 coming soon) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932135Ab0GAS1j (ORCPT ); Thu, 1 Jul 2010 14:27:39 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:59253 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758276Ab0GAS1c (ORCPT ); Thu, 1 Jul 2010 14:27:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=mS1AEz46zkCI2nSpcFVQsVaPYLO1hu6BYV1N7L+upHbejS08nAURzlfJaVoRF4eKxS C+3147FpR6nRwSfexzfON24FlAepYrAcZGbHEqXcmjfsDgkIVymuEu650qGJfvCmrvyG gQaq+cqQwyTO5J/mG3+pnTu379/F+lIy84V4s= Date: Thu, 1 Jul 2010 22:27:24 +0400 From: Kulikov Vasiliy To: Dan Carpenter , Kernel Janitors , Doug Gilbert , "James E.J. Bottomley" , Andrew Morton , FUJITA Tomonori , Jens Axboe , Alexey Dobriyan , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/25] scsi/sg: remove casts from void* Message-ID: <20100701182724.GA22466@shinshilla> References: <1277990204-22157-1-git-send-email-segooon@gmail.com> <20100701173805.GW19184@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100701173805.GW19184@bicker> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 01, 2010 at 19:38 +0200, Dan Carpenter wrote: > On Thu, Jul 01, 2010 at 05:16:43PM +0400, Kulikov Vasiliy wrote: > > - Sg_fd *sfp; > > + Sg_fd *sfp = filp->private_data; > ^^^^^^^^^^^^^^^^^^ > Dereferenced here. > > > unsigned long req_sz, len, sa; > > Sg_scatter_hold *rsv_schp; > > int k, length; > > > > - if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data))) > > + if ((!filp) || (!vma) || !(sfp)) > ^^^^^ > > Checked here. Oops, I've loosed it... The problem is that this driver is not even compileable. Patch v2 coming soon)