All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] base-files: profile: don't set TZ if /etc/TZ is present
Date: Fri, 2 Jul 2010 21:55:04 -0700	[thread overview]
Message-ID: <20100703045504.GB17627@gmail.com> (raw)
In-Reply-To: <1278082654-10070-3-git-send-email-khimov@altell.ru>

On (02/07/10 18:57), Roman I Khimov wrote:
> uClibc-based systems can have system-wide TZ in /etc/TZ, thus we shouldn't
> set TZ variable if it is present.
> 
> Signed-off-by: Roman I Khimov <khimov@altell.ru>

Acked-by: Khem Raj <raj.khem@gmail.com>

what all shells did you test it on.

> ---
>  recipes/base-files/base-files/jornada6xx/profile   |    2 +-
>  .../base-files/base-files/omap3-pandora/profile    |    2 +-
>  .../base-files/base-files/oplinux-uclibc/profile   |    2 +-
>  recipes/base-files/base-files/oplinux/profile      |    2 +-
>  recipes/base-files/base-files/profile              |    2 +-
>  recipes/base-files/base-files/shr/profile          |    2 +-
>  recipes/base-files/base-files_3.0.14.bb            |    2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/recipes/base-files/base-files/jornada6xx/profile b/recipes/base-files/base-files/jornada6xx/profile
> index bff0f42..bd9e3e6 100755
> --- a/recipes/base-files/base-files/jornada6xx/profile
> +++ b/recipes/base-files/base-files/jornada6xx/profile
> @@ -9,7 +9,7 @@ if [ "`id -u`" -eq 0 ]; then
>     PATH="$PATH:/sbin:/usr/sbin:/usr/local/sbin"
>  fi
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files/omap3-pandora/profile b/recipes/base-files/base-files/omap3-pandora/profile
> index 5797535..99b6fce 100644
> --- a/recipes/base-files/base-files/omap3-pandora/profile
> +++ b/recipes/base-files/base-files/omap3-pandora/profile
> @@ -5,7 +5,7 @@ PATH="/usr/local/bin:/usr/bin:/bin"
>  EDITOR="/bin/vi"			# needed for packages like cron
>  test -z "$TERM" && TERM="vt100"	# Basic terminal capab. For screen etc.
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files/oplinux-uclibc/profile b/recipes/base-files/base-files/oplinux-uclibc/profile
> index f6ae329..5ad2967 100644
> --- a/recipes/base-files/base-files/oplinux-uclibc/profile
> +++ b/recipes/base-files/base-files/oplinux-uclibc/profile
> @@ -5,7 +5,7 @@ PATH="/usr/local/bin:/usr/bin:/bin"
>  EDITOR="/usr/bin/nano"	# needed for packages like cron
>  TERM="linux"		# Basic terminal capab. For screen etc.
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files/oplinux/profile b/recipes/base-files/base-files/oplinux/profile
> index f6ae329..5ad2967 100644
> --- a/recipes/base-files/base-files/oplinux/profile
> +++ b/recipes/base-files/base-files/oplinux/profile
> @@ -5,7 +5,7 @@ PATH="/usr/local/bin:/usr/bin:/bin"
>  EDITOR="/usr/bin/nano"	# needed for packages like cron
>  TERM="linux"		# Basic terminal capab. For screen etc.
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
> index b5ce69d..8f7f6b5 100644
> --- a/recipes/base-files/base-files/profile
> +++ b/recipes/base-files/base-files/profile
> @@ -5,7 +5,7 @@ PATH="/usr/local/bin:/usr/bin:/bin"
>  EDITOR="/bin/vi"			# needed for packages like cron
>  test -z "$TERM" && TERM="vt100"	# Basic terminal capab. For screen etc.
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files/shr/profile b/recipes/base-files/base-files/shr/profile
> index 05e8490..6e11e81 100644
> --- a/recipes/base-files/base-files/shr/profile
> +++ b/recipes/base-files/base-files/shr/profile
> @@ -5,7 +5,7 @@ PATH="/usr/local/bin:/usr/bin:/bin"
>  EDITOR="/bin/vi"			# needed for packages like cron
>  test -z "$TERM" && TERM="vt100"	# Basic terminal capab. For screen etc.
>  
> -if [ ! -e /etc/localtime ]; then
> +if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
>  	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
>  				# for an explanation of how to set this to your local timezone.
>  	export TZ
> diff --git a/recipes/base-files/base-files_3.0.14.bb b/recipes/base-files/base-files_3.0.14.bb
> index 9801f8a..02bd39b 100644
> --- a/recipes/base-files/base-files_3.0.14.bb
> +++ b/recipes/base-files/base-files_3.0.14.bb
> @@ -1,7 +1,7 @@
>  DESCRIPTION = "Miscellaneous files for the base system."
>  SECTION = "base"
>  PRIORITY = "required"
> -PR = "r94"
> +PR = "r95"
>  LICENSE = "GPL"
>  
>  SRC_URI = " \
> -- 
> 1.5.6.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2010-07-03  4:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 14:57 [PATCH] tzdata: fix RPROVIDES definitions Roman I Khimov
2010-07-02 14:57 ` [PATCH] tzdata-uclibc: add recipe for uclibc timezone database Roman I Khimov
2010-07-02 14:57   ` [PATCH] base-files: profile: don't set TZ if /etc/TZ is present Roman I Khimov
2010-07-03  4:55     ` Khem Raj [this message]
2010-07-03  5:52       ` Roman I Khimov
2010-07-03  4:51   ` [PATCH] tzdata-uclibc: add recipe for uclibc timezone database Khem Raj
2010-07-03  5:38     ` Roman I Khimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100703045504.GB17627@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.