From: Gleb Natapov <gleb@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>
Subject: Re: [PATCH v2] KVM: IOAPIC: only access APIC registers one dword at a time
Date: Mon, 5 Jul 2010 09:23:57 +0300 [thread overview]
Message-ID: <20100705062357.GH4689@redhat.com> (raw)
In-Reply-To: <4C3155BA.4070903@cn.fujitsu.com>
On Mon, Jul 05, 2010 at 11:47:06AM +0800, Xiao Guangrong wrote:
> > There might be guests that use incorrect access despite the
> > documentation; if real hardware supports it, it should work. So we need
> > to start with just a warning, and allow the access. Later we can drop
> > the invalid access.
>
> If the OS contravene the spec, i thinks it's the OS's bug, also, i have tested some versions
> windows/linux guests, it's no broken, can we directly drop the other wide access?
>
If reality contradicts spec we should emulate reality. I vaguely
remember some guest using memcpy on apic page for instance.
--
Gleb.
next prev parent reply other threads:[~2010-07-05 6:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 4:38 [PATCH] KVM: IOAPIC: only access APIC registers one dword at a time Xiao Guangrong
2010-07-02 7:31 ` Jin Dongming
2010-07-02 7:38 ` Xiao Guangrong
2010-07-02 8:00 ` [PATCH v2] " Xiao Guangrong
2010-07-02 17:42 ` Marcelo Tosatti
2010-07-03 8:20 ` Xiao Guangrong
2010-07-03 10:11 ` Avi Kivity
2010-07-05 3:47 ` Xiao Guangrong
2010-07-05 6:23 ` Gleb Natapov [this message]
2010-07-05 7:54 ` Avi Kivity
2010-07-05 7:56 ` Xiao Guangrong
2010-07-05 8:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705062357.GH4689@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.