From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: multipath mux question
Date: Mon, 5 Jul 2010 10:36:44 +0300 [thread overview]
Message-ID: <20100705073642.GB15951@atomide.com> (raw)
In-Reply-To: <AANLkTikb2w3is46Gw-r22F9n2Ockx5rzOWHGo49cnQ8G@mail.gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [100703 00:21]:
> Hi,
>
> on OMAP3 CBB package GPIO126 can be muxed on 2 pins: mmc1_dat4 and
> cam_strobe. On pandora mmc1_dat4 is connected to mmc1 write protect,
> this makes omap2_mmc_mux() call omap_mux_init_gpio() on GPIO126, which
> muxes both pins and warns:
> mux: Multiple gpio paths for gpio126
OK.
> This results in unusable GPIO. I wonder how should I handle this,
> perhaps overriding mux by calling omap_mux_init_signal() after
> omap2_hsmmc_init() call? Or maybe omap_mux_init_gpio() should be
> patched not to set up GPIOs if it encounters multiple paths?
To me the safest route is the second option you suggest where
we refuse to mux GPIO pins that have multiple outputs.
We should just print a warning and return an error. Then we should
also start checking the return values for omap_mux_init_gpio
now that the code is converted over to use the new mux code.
If you do a patch, please do it against omap for-next branch
as omap_mux_init_gpio has a pending patch for MUXABLE_GPIO_MODE3.
Regards,
Tony
next prev parent reply other threads:[~2010-07-05 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 21:28 multipath mux question Grazvydas Ignotas
2010-07-05 7:36 ` Tony Lindgren [this message]
2010-07-05 11:49 ` Grazvydas Ignotas
2010-07-05 13:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705073642.GB15951@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.