Re: [PATCH] [omap1] Bluetooth device code common to HTC smartphones

[Tony Lindgren <tony@atomide.com>]

* Cory Maccarrone <darkstar6262@gmail.com> [100602 01:27]:
> This change adds in a bluetooth controld driver/rfkill
> interface to the serial bluetooth controller found on many
> HTC smartphones such as the HTC Herald and HTC Wizard.

<snip>
 
> +static void htc_bt_on(struct htc_bt_data *data)
> +{
> +	gpio_set_value(data->gpio_pwr, 1);
> +
> +	if (uart_ck)
> +		clk_enable(uart_ck);
> +
> +	mdelay(1000);
> +
> +	if (data->gpio_enable)
> +		gpio_set_value(data->gpio_enable, 1);
> +}

Maybe you can use msleep here instead? Otherwise the whole system
will hang for a second..

> +static void htc_bt_off(struct htc_bt_data *data)
> +{
> +	gpio_set_value(data->gpio_pwr, 0);
> +
> +	if (uart_ck)
> +		clk_disable(uart_ck);
> +
> +	mdelay(1000);
> +
> +	if (data->gpio_enable)
> +		gpio_set_value(data->gpio_enable, 0);
> +}

Here too.

Regards,

Tony