From: tytso@mit.edu
To: Eric Sandeen <sandeen@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Rearrange i_flags to be consistent with FS_IOC_GETFLAGS
Date: Mon, 5 Jul 2010 13:27:18 -0400 [thread overview]
Message-ID: <20100705172718.GE25518@thunk.org> (raw)
In-Reply-To: <4C32001F.8060906@redhat.com>
On Mon, Jul 05, 2010 at 10:54:07AM -0500, Eric Sandeen wrote:
>
> ... a stern comment here about not re-ordering since other fs/*/*
> code depends strongly on this order?
A stern warning is needed there, but it's also needed a few lines
further down in the inode flags section where the FS_*_FL flags are
defined. These were originally ext2-specific inode flags, and it's
become generalized to a fs-independent set of bit fields, but what's
nasty/important to remember is that these flags are also used as
on-disk flags for ext2/3/4, and so extreme care is needed before new
flags are for FS_IOC_GETFLAGS/FS_IOC_SETFLAGS are allocated....
In fact, I'd argue it's much more strongly needed for the FS_*_FL
flags.
- Ted
next prev parent reply other threads:[~2010-07-05 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 15:43 [PATCH] Rearrange i_flags to be consistent with FS_IOC_GETFLAGS David Howells
2010-07-05 15:54 ` Eric Sandeen
2010-07-05 17:27 ` tytso [this message]
2010-07-06 0:10 ` Dave Chinner
2010-07-06 13:40 ` David Howells
2010-07-06 23:03 ` Dave Chinner
2010-07-06 23:45 ` David Howells
2010-07-07 1:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705172718.GE25518@thunk.org \
--to=tytso@mit.edu \
--cc=dhowells@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.