From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36150 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWJaY-0008AS-Nf
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:38:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OWJaX-00018n-Km
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:38:14 -0400
Received: from verein.lst.de ([213.95.11.210]:39092)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OWJaX-00018V-7g
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:38:13 -0400
Date: Wed, 7 Jul 2010 03:38:12 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20100707013812.GG3073@lst.de>
References: <1278419869-26126-1-git-send-email-armbru@redhat.com>
	<1278419869-26126-8-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1278419869-26126-8-git-send-email-armbru@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 7/8] blockdev: Store -drive option media in
	DriveInfo
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

I'd rather have an enum about the drive type instead of the is_cdrom
flag.  In addition I think patch 8 should be folded into this one.