From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] writeback: Add tracing to balance_dirty_pages
Date: Wed, 7 Jul 2010 13:11:45 +1000 [thread overview]
Message-ID: <20100707031145.GH25018@dastard> (raw)
In-Reply-To: <20100707022055.GB17385@infradead.org>
On Tue, Jul 06, 2010 at 10:20:55PM -0400, Christoph Hellwig wrote:
> > +
> > + TP_fast_assign(
> > + char *__no_bdi = "(no bdi)";
> > +
> > + if (bdi)
> > + strncpy(__entry->name, dev_name(bdi->dev), 32);
> > + else
> > + strncpy(__entry->name, __no_bdi, 32);
>
> I can't see a caller that doesn't have a bdi.
True. I think that was left over from the previous version where
the bdi could be null. I'll fix it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-07-07 3:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 23:41 [PATCH 0/3] writeback: Tracing support V2 Dave Chinner
2010-07-06 23:41 ` [PATCH 1/3] writeback: Initial tracing support Dave Chinner
2010-07-07 2:19 ` Christoph Hellwig
2010-07-07 3:06 ` Dave Chinner
2010-07-06 23:41 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-07-07 2:20 ` Christoph Hellwig
2010-07-07 3:11 ` Dave Chinner [this message]
2010-07-06 23:41 ` [PATCH 3/3] writeback: Add tracing to write_cache_pages Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 3:24 [PATCH 0/3] writeback: Tracing support V3 Dave Chinner
2010-07-07 3:24 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-06-21 1:25 [PATCH 0/3] writeback: tracing support Dave Chinner
2010-06-21 1:25 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-06-21 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707031145.GH25018@dastard \
--to=david@fromorbit.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.