[U-Boot] [PATCH v1]ppc4xx/Canyonlands added USB board callbacks

[Wolfgang Denk <wd@denx.de>]

Dear Rupjyoti Sarmah,

In message <201007070632.o676WvS8029128@amcc.com> you wrote:
> Functions added to support board callbacks for USB init. This
> isolates USB manipulations such that it is only touched if USB is
> used by U-Boot.
> 
> Signed-off-by: Dave Mitchell <dmitchell@appliedmicro.com>
> Signed-off-by: Rupjyoti Sarmah <rsarmah@appliedmicro.com>
> ---
> This patch incorporates the changes advised.

>  	if (pvr_460ex()) {
>  		printf("Board: Canyonlands - AMCC PPC460EX Evaluation Board");
> -		if (in_8((void *)(CONFIG_SYS_BCSR_BASE + 3)) & CONFIG_SYS_BCSR3_PCIE)
> +		if (bcsr_data->board_status & CONFIG_SYS_BCSR3_PCIE)

Please use I/O accessors to read the BCSR.

> -	printf(", Rev. %X", in_8((void *)(CONFIG_SYS_BCSR_BASE + 0)));
> +	printf(", Rev. %X", bcsr_data->cpld_rev);

Ditto. There are more changes like this - please fix all of them.

> --- a/include/configs/canyonlands.h
> +++ b/include/configs/canyonlands.h
> @@ -77,6 +77,18 @@
>  #define CONFIG_SYS_PCIE0_XCFGBASE	0xc3000000
>  #define CONFIG_SYS_PCIE1_XCFGBASE	0xc3001000
>  
> +/*
> + * BCSR bits as defined in the ep460c board user manual
> + */

What is "ep460c"? We know 460EX (the CPU) and Canyonlands (the board).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is  a  nanocentury.
                                               -- Tom Duff, Bell Labs