All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: [PATCH 1/2] QMP: Introduce the documentation for query-qdm
Date: Wed, 7 Jul 2010 10:07:09 -0300	[thread overview]
Message-ID: <20100707100709.27a9a9e7@redhat.com> (raw)
In-Reply-To: <AANLkTim9xU28c6FcgDvXoPN352ntG8UwxpkVQX8Ak7Jy@mail.gmail.com>

On Mon, 5 Jul 2010 16:34:22 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> Possible values for "type" are defined in the patch on the
> qdev_property_type_to_string() function. To spot them in the current
> code, hw/qdev.c:77:
> 
> enum PropertyType {
>     PROP_TYPE_UNSPEC = 0,
>     PROP_TYPE_UINT8,
>     PROP_TYPE_UINT16,
>     PROP_TYPE_UINT32,
>     PROP_TYPE_INT32,
>     PROP_TYPE_UINT64,
>     PROP_TYPE_TADDR,
>     PROP_TYPE_MACADDR,
>     PROP_TYPE_DRIVE,
>     PROP_TYPE_CHR,
>     PROP_TYPE_STRING,
>     PROP_TYPE_NETDEV,
>     PROP_TYPE_VLAN,
>     PROP_TYPE_PTR,
>     PROP_TYPE_BIT,
> };
> 
> So it is a mix of json-(string|integer|boolean). It seams to me that a
> device_add using QMP will use just use strings. Need to confirm that.

There are integers too.

Daniel, can you clarify how libvirt is going to use this member?

Maybe we could have something like this:

 "type": { "qdev": "macaddr", "qmp": "string" }

  reply	other threads:[~2010-07-07 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 21:27 [Qemu-devel] [PATCH 0/2] QMP: Introduce query-qdm Miguel Di Ciurcio Filho
2010-07-02 21:27 ` [Qemu-devel] [PATCH 1/2] QMP: Introduce the documentation for query-qdm Miguel Di Ciurcio Filho
2010-07-04  5:14   ` [Qemu-devel] " Avi Kivity
2010-07-05 13:20     ` Miguel Di Ciurcio Filho
2010-07-05 15:22   ` Luiz Capitulino
2010-07-05 19:34     ` Miguel Di Ciurcio Filho
2010-07-07 13:07       ` Luiz Capitulino [this message]
2010-07-07 13:39         ` Daniel P. Berrange
2010-07-02 21:27 ` [Qemu-devel] [PATCH 2/2] monitor: Convert 'info qdm' to QMP Miguel Di Ciurcio Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100707100709.27a9a9e7@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.