From: "Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] dracut-functions: find_rule a bit smarter; thanks to V. Lowther
Date: Wed, 7 Jul 2010 12:27:55 +0200 [thread overview]
Message-ID: <20100707122755.2b1b8214@etiriah> (raw)
In-Reply-To: <20100707111946.568b4775@etiriah>
[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]
Matches rules filename if it's specified without prefix number.
Thanks to Victor Lowther for advice of not using ls command. Use
globbing and parameter expansion instead.
---
dracut-functions | 31 +++++++++++++++++++++++++++----
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/dracut-functions b/dracut-functions
index 0caf0d6..7a1d82f 100755
--- a/dracut-functions
+++ b/dracut-functions
@@ -319,13 +319,36 @@ inst_symlink() {
inst "$realsrc" && ln -s "$realsrc" "$target"
}
-# find a udev rule in the usual places.
+# find a udev rule in the usual places and try to be smart (just a bit).
+# See example:
+# find_rule default.rules
+# find_rule 50-default.rules
+# All of them will return: /lib/udev/rules.d/50-udev-default.rules
+# If there are few matching files, error message is printed.
find_rule() {
+ local rd f files=()
+
[[ -f $1 ]] && { echo "$1"; return 0; }
- for r in . /lib/udev/rules.d /etc/udev/rules.d $dracutbasedir/rules.d; do
- [[ -f $r/$1 ]] && { echo "$r/$1"; return 0; }
+
+ for rd in . /lib/udev/rules.d /etc/udev/rules.d $dracutbasedir/rules.d; do
+ for f in "$rd/$1" "$rd"/*-"$1"
+ do
+ [[ -f $f ]] || continue
+ [[ ${f##*/} =~ [0-9][0-9]-.*\.rules ]] || continue
+ files+=($f)
+ done
+ # If detecting ambiguousness among different directories isn't desired,
+ # uncomment this:
+ # (( ${#files[@]} >= 1 )) && break
done
- return 1
+
+ (( ${#files[@]} < 1 )) && return 1
+ (( ${#files[@]} > 1 )) && {
+ derror "Ambigous rules filename. Matches: ${files[@]}"
+ return 1
+ }
+
+ echo "$files"
}
# udev rules always get installed in the same place, so
--
1.7.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-07-07 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 7:06 [PATCH 1/3] dracut: info which module is sourced; updated dracut usage Amadeusz Żołnowski
2010-07-05 7:08 ` [PATCH 2/3] dracut-functions: info which udev rules are skipped Amadeusz Żołnowski
2010-07-05 7:12 ` [PATCH 3/3] dracut-functions: find_rule a bit smarter Amadeusz Żołnowski
2010-07-05 9:24 ` Amadeusz Żołnowski
2010-07-05 14:53 ` Victor Lowther
[not found] ` <1278341637.4056.17.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-07-07 9:19 ` Amadeusz Żołnowski
2010-07-07 10:27 ` Amadeusz Żołnowski [this message]
2010-07-09 13:48 ` [PATCH 2/3] dracut-functions: info which udev rules are skipped Harald Hoyer
2010-07-09 13:47 ` [PATCH 1/3] dracut: info which module is sourced; updated dracut usage Harald Hoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707122755.2b1b8214@etiriah \
--to=aidecoe-2qtfh70ttyba5ebddlwbiw@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.